You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/02/09 02:44:41 UTC

[GitHub] [skywalking] lujiajing1126 opened a new issue #8514: [Bug] TimeRange in the query is out of range

lujiajing1126 opened a new issue #8514:
URL: https://github.com/apache/skywalking/issues/8514


   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Apache SkyWalking Component
   
   BanyanDB (apache/skywalking-banyandb)
   
   ### What happened
   
   For the well-known [`timestamp`](https://developers.google.com/protocol-buffers/docs/reference/google.protobuf#timestamp) type from protobuf,
   
   > Range is from 0001-01-01T00:00:00Z to 9999-12-31T23:59:59.999999999Z. By restricting to that range, we ensure that we can convert to and from RFC 3339 date strings. See https://www.ietf.org/rfc/rfc3339.txt.
   
   However, in the implementation of BanyanDB, the bound of time (epoch nanoseconds) is represented by the type of `int64`, thus the time range should adhere to this limitation.
   
   https://github.com/apache/skywalking-banyandb/blob/b61ab295c38c672ca7aa60e308d0d64037272766/banyand/tsdb/series_seek_sort.go#L113-L116
   
   ### What you expected to happen
   
   The time range should be limited by the bound from `1677-09-21 00:12:43.145224194` to `2262-04-11T23:47:16.854775806Z`.
   
   1. The `sw-banyandb-java-client` should impose this range check.
   2. The liaison module should validate this boundary.
   3. OAP storage module should be careful with this.
   
   ### How to reproduce
   
   For example, use `9999-12-31T23:59:59.999999999Z` as the upper bound of the time range, we would get nothing from the database which is not expected.
   
   ### Anything else
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #8514: [Bug] TimeRange in the query is out of range

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #8514:
URL: https://github.com/apache/skywalking/issues/8514#issuecomment-1033310571


   `int64` should represent the millisecond. If protocol is expecting nanoseconds, how about we use timestamp rather than int64? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org