You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "jadami10 (via GitHub)" <gi...@apache.org> on 2023/07/16 21:41:03 UTC
[GitHub] [pinot] jadami10 opened a new issue, #11119: Broker query log breaks into multiple lines breaking logging infrastructure
jadami10 opened a new issue, #11119:
URL: https://github.com/apache/pinot/issues/11119
The broker query logs contain a field with `query=`. That field always has spaces, sometimes new lines, and potentially double quotes. This makes logging infra, like splunk, not parse it correctly as "key=value"
Would we have any concerns with
1. double quoting the query
2. escaping double quotes in the query
We have a [test](https://github.com/apache/pinot/blob/c32318360e46a4030bfbff9d11f57b7fa0564397/pinot-broker/src/test/java/org/apache/pinot/broker/querylog/QueryLoggerTest.java#L113) for this, so i'm not sure if folks are relying on this. But if so, this would be a backwards incompatible change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on issue #11119: Broker query log breaks into multiple lines breaking logging infrastructure
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on issue #11119:
URL: https://github.com/apache/pinot/issues/11119#issuecomment-1644461443
Is there alternative character that can mark the query? Does '`' work?
My concern with double quote is that it will change the query and could cause confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] jadami10 commented on issue #11119: Broker query log breaks into multiple lines breaking logging infrastructure
Posted by "jadami10 (via GitHub)" <gi...@apache.org>.
jadami10 commented on issue #11119:
URL: https://github.com/apache/pinot/issues/11119#issuecomment-1644470966
I actually forgot to mention that we would need to remove or escape new lines as well to get it all into 1 line. We can probably proxy all of our queries and have a separate log, it'll just be expensive from a logging standpoint. I wonder how other folks get around this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org