You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Jarcec Cecho <ja...@apache.org> on 2013/07/02 22:50:19 UTC
Pre commit hooks for Sqoop project
Dear Sqoop developers,
in SQOOP-1082, we've started working on PreCommit hooks for Sqoop that will automatically apply and test each submitted patch. This will for example allow us to run tests on reference architecture (Jenkins slaves) before committing the change! I would like to mention that this work has been finalized. Every 10 minutes all opened Sqoop issues in state "Patch Available" will be scanned for new attachments and subsequently special Jenkins job will test them out updating the JIRA with the results. You can take a look on example report on SQOOP-997 [1].
In order for the PreCommit hook to test your patch it needs to be named in form (bug)SQOOP-$number.$suffix, where $number stands for the JIRA number and $suffix can be one of "patch", "txt" or "patch.txt". You can also version the patches by appending dash or dot after the JIRA number followed by sequence number. You can take a look on used regular expression in [2]. Couple of valid examples for JIRA SQOOP-666:
* bugSQOOP-666.patch
* SQOOP-666.txt
* bugSQOOP-666-1.patch
* SQOOP-666.1.txt
Jarcec
Links:
1: https://issues.apache.org/jira/browse/SQOOP-997
2: https://github.com/apache/sqoop/blob/sqoop2/dev-support/test-patch.py#L138
Re: Pre commit hooks for Sqoop project
Posted by Jarek Jarcec Cecho <ja...@apache.org>.
Ideas are most often the hardest part!
Jarcec
On Wed, Jul 03, 2013 at 03:15:02PM -0700, Venkat Ranganathan wrote:
> Ideas are easy:)
>
>
> On Tue, Jul 2, 2013 at 2:10 PM, Jarek Jarcec Cecho <ja...@apache.org>wrote:
>
> > The biggest thank you belongs to Venkat who came up with the idea!
> >
> > Jarcec
> >
> > On Tue, Jul 02, 2013 at 02:00:25PM -0700, Hari Shreedharan wrote:
> > > Great work, Jarcec! Much appreciated, thanks!
> > >
> > >
> > > Hari
> > >
> > >
> > > On Tuesday, July 2, 2013 at 1:50 PM, Jarek Jarcec Cecho wrote:
> > >
> > > > Dear Sqoop developers,
> > > > in SQOOP-1082, we've started working on PreCommit hooks for Sqoop that
> > will automatically apply and test each submitted patch. This will for
> > example allow us to run tests on reference architecture (Jenkins slaves)
> > before committing the change! I would like to mention that this work has
> > been finalized. Every 10 minutes all opened Sqoop issues in state "Patch
> > Available" will be scanned for new attachments and subsequently special
> > Jenkins job will test them out updating the JIRA with the results. You can
> > take a look on example report on SQOOP-997 [1].
> > > >
> > > > In order for the PreCommit hook to test your patch it needs to be
> > named in form (bug)SQOOP-$number.$suffix, where $number stands for the JIRA
> > number and $suffix can be one of "patch", "txt" or "patch.txt". You can
> > also version the patches by appending dash or dot after the JIRA number
> > followed by sequence number. You can take a look on used regular expression
> > in [2]. Couple of valid examples for JIRA SQOOP-666:
> > > >
> > > > * bugSQOOP-666.patch
> > > > * SQOOP-666.txt
> > > > * bugSQOOP-666-1.patch
> > > > * SQOOP-666.1.txt
> > > >
> > > > Jarcec
> > > >
> > > > Links:
> > > > 1: https://issues.apache.org/jira/browse/SQOOP-997
> > > > 2:
> > https://github.com/apache/sqoop/blob/sqoop2/dev-support/test-patch.py#L138
> > > >
> > > >
> > >
> > >
> >
Re: Pre commit hooks for Sqoop project
Posted by Venkat Ranganathan <vr...@hortonworks.com>.
Thanks a lot for all the work Jarcec. Very much appreciated
On Wed, Jul 3, 2013 at 3:15 PM, Venkat Ranganathan <
vranganathan@hortonworks.com> wrote:
> Ideas are easy:)
>
>
> On Tue, Jul 2, 2013 at 2:10 PM, Jarek Jarcec Cecho <ja...@apache.org>wrote:
>
>> The biggest thank you belongs to Venkat who came up with the idea!
>>
>> Jarcec
>>
>> On Tue, Jul 02, 2013 at 02:00:25PM -0700, Hari Shreedharan wrote:
>> > Great work, Jarcec! Much appreciated, thanks!
>> >
>> >
>> > Hari
>> >
>> >
>> > On Tuesday, July 2, 2013 at 1:50 PM, Jarek Jarcec Cecho wrote:
>> >
>> > > Dear Sqoop developers,
>> > > in SQOOP-1082, we've started working on PreCommit hooks for Sqoop
>> that will automatically apply and test each submitted patch. This will for
>> example allow us to run tests on reference architecture (Jenkins slaves)
>> before committing the change! I would like to mention that this work has
>> been finalized. Every 10 minutes all opened Sqoop issues in state "Patch
>> Available" will be scanned for new attachments and subsequently special
>> Jenkins job will test them out updating the JIRA with the results. You can
>> take a look on example report on SQOOP-997 [1].
>> > >
>> > > In order for the PreCommit hook to test your patch it needs to be
>> named in form (bug)SQOOP-$number.$suffix, where $number stands for the JIRA
>> number and $suffix can be one of "patch", "txt" or "patch.txt". You can
>> also version the patches by appending dash or dot after the JIRA number
>> followed by sequence number. You can take a look on used regular expression
>> in [2]. Couple of valid examples for JIRA SQOOP-666:
>> > >
>> > > * bugSQOOP-666.patch
>> > > * SQOOP-666.txt
>> > > * bugSQOOP-666-1.patch
>> > > * SQOOP-666.1.txt
>> > >
>> > > Jarcec
>> > >
>> > > Links:
>> > > 1: https://issues.apache.org/jira/browse/SQOOP-997
>> > > 2:
>> https://github.com/apache/sqoop/blob/sqoop2/dev-support/test-patch.py#L138
>> > >
>> > >
>> >
>> >
>>
>
>
Re: Pre commit hooks for Sqoop project
Posted by Venkat Ranganathan <vr...@hortonworks.com>.
Ideas are easy:)
On Tue, Jul 2, 2013 at 2:10 PM, Jarek Jarcec Cecho <ja...@apache.org>wrote:
> The biggest thank you belongs to Venkat who came up with the idea!
>
> Jarcec
>
> On Tue, Jul 02, 2013 at 02:00:25PM -0700, Hari Shreedharan wrote:
> > Great work, Jarcec! Much appreciated, thanks!
> >
> >
> > Hari
> >
> >
> > On Tuesday, July 2, 2013 at 1:50 PM, Jarek Jarcec Cecho wrote:
> >
> > > Dear Sqoop developers,
> > > in SQOOP-1082, we've started working on PreCommit hooks for Sqoop that
> will automatically apply and test each submitted patch. This will for
> example allow us to run tests on reference architecture (Jenkins slaves)
> before committing the change! I would like to mention that this work has
> been finalized. Every 10 minutes all opened Sqoop issues in state "Patch
> Available" will be scanned for new attachments and subsequently special
> Jenkins job will test them out updating the JIRA with the results. You can
> take a look on example report on SQOOP-997 [1].
> > >
> > > In order for the PreCommit hook to test your patch it needs to be
> named in form (bug)SQOOP-$number.$suffix, where $number stands for the JIRA
> number and $suffix can be one of "patch", "txt" or "patch.txt". You can
> also version the patches by appending dash or dot after the JIRA number
> followed by sequence number. You can take a look on used regular expression
> in [2]. Couple of valid examples for JIRA SQOOP-666:
> > >
> > > * bugSQOOP-666.patch
> > > * SQOOP-666.txt
> > > * bugSQOOP-666-1.patch
> > > * SQOOP-666.1.txt
> > >
> > > Jarcec
> > >
> > > Links:
> > > 1: https://issues.apache.org/jira/browse/SQOOP-997
> > > 2:
> https://github.com/apache/sqoop/blob/sqoop2/dev-support/test-patch.py#L138
> > >
> > >
> >
> >
>
Re: Pre commit hooks for Sqoop project
Posted by Jarek Jarcec Cecho <ja...@apache.org>.
The biggest thank you belongs to Venkat who came up with the idea!
Jarcec
On Tue, Jul 02, 2013 at 02:00:25PM -0700, Hari Shreedharan wrote:
> Great work, Jarcec! Much appreciated, thanks!
>
>
> Hari
>
>
> On Tuesday, July 2, 2013 at 1:50 PM, Jarek Jarcec Cecho wrote:
>
> > Dear Sqoop developers,
> > in SQOOP-1082, we've started working on PreCommit hooks for Sqoop that will automatically apply and test each submitted patch. This will for example allow us to run tests on reference architecture (Jenkins slaves) before committing the change! I would like to mention that this work has been finalized. Every 10 minutes all opened Sqoop issues in state "Patch Available" will be scanned for new attachments and subsequently special Jenkins job will test them out updating the JIRA with the results. You can take a look on example report on SQOOP-997 [1].
> >
> > In order for the PreCommit hook to test your patch it needs to be named in form (bug)SQOOP-$number.$suffix, where $number stands for the JIRA number and $suffix can be one of "patch", "txt" or "patch.txt". You can also version the patches by appending dash or dot after the JIRA number followed by sequence number. You can take a look on used regular expression in [2]. Couple of valid examples for JIRA SQOOP-666:
> >
> > * bugSQOOP-666.patch
> > * SQOOP-666.txt
> > * bugSQOOP-666-1.patch
> > * SQOOP-666.1.txt
> >
> > Jarcec
> >
> > Links:
> > 1: https://issues.apache.org/jira/browse/SQOOP-997
> > 2: https://github.com/apache/sqoop/blob/sqoop2/dev-support/test-patch.py#L138
> >
> >
>
>
Re: Pre commit hooks for Sqoop project
Posted by Hari Shreedharan <hs...@cloudera.com>.
Great work, Jarcec! Much appreciated, thanks!
Hari
On Tuesday, July 2, 2013 at 1:50 PM, Jarek Jarcec Cecho wrote:
> Dear Sqoop developers,
> in SQOOP-1082, we've started working on PreCommit hooks for Sqoop that will automatically apply and test each submitted patch. This will for example allow us to run tests on reference architecture (Jenkins slaves) before committing the change! I would like to mention that this work has been finalized. Every 10 minutes all opened Sqoop issues in state "Patch Available" will be scanned for new attachments and subsequently special Jenkins job will test them out updating the JIRA with the results. You can take a look on example report on SQOOP-997 [1].
>
> In order for the PreCommit hook to test your patch it needs to be named in form (bug)SQOOP-$number.$suffix, where $number stands for the JIRA number and $suffix can be one of "patch", "txt" or "patch.txt". You can also version the patches by appending dash or dot after the JIRA number followed by sequence number. You can take a look on used regular expression in [2]. Couple of valid examples for JIRA SQOOP-666:
>
> * bugSQOOP-666.patch
> * SQOOP-666.txt
> * bugSQOOP-666-1.patch
> * SQOOP-666.1.txt
>
> Jarcec
>
> Links:
> 1: https://issues.apache.org/jira/browse/SQOOP-997
> 2: https://github.com/apache/sqoop/blob/sqoop2/dev-support/test-patch.py#L138
>
>