You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Robert Levas <rl...@hortonworks.com> on 2016/04/22 22:44:48 UTC
Review Request 46583: Stack Advisor issue when adding service to
Kerberized cluster
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46583/
-----------------------------------------------------------
Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, Oliver Szabo, and Sumit Mohanty.
Bugs: AMBARI-16079
https://issues.apache.org/jira/browse/AMBARI-16079
Repository: ambari
Description
-------
When adding a service to a Kerberized cluster and click install nothing happens on the UI and i see the following error in the ambari server logs
```
20 Apr 2016 16:03:56,818 INFO [qtp-ambari-client-2764] KerberosHelperImpl:735 - Adding identity for JOURNALNODE to auth to local mapping
20 Apr 2016 16:03:56,818 INFO [qtp-ambari-client-2764] KerberosHelperImpl:735 - Adding identity for METRICS_COLLECTOR to auth to local mapping
20 Apr 2016 16:03:56,857 INFO [qtp-ambari-client-2764] StackAdvisorRunner:47 - Script=/var/lib/ambari-server/resources/scripts/stack_advisor.py, actionDirectory=/var/run/ambari-server/stack-recommendations/323, command=recommend-configurations
20 Apr 2016 16:03:56,860 INFO [qtp-ambari-client-2764] StackAdvisorRunner:61 - Stack-advisor output=/var/run/ambari-server/stack-recommendations/323/stackadvisor.out, error=/var/run/ambari-server/stack-recommendations/323/stackadvisor.err
20 Apr 2016 16:03:56,917 INFO [qtp-ambari-client-2764] StackAdvisorRunner:69 - Stack advisor output files
20 Apr 2016 16:03:56,917 INFO [qtp-ambari-client-2764] StackAdvisorRunner:70 - advisor script stdout: StackAdvisor implementation for stack HDP, version 2.0.6 was loaded
StackAdvisor implementation for stack HDP, version 2.1 was loaded
StackAdvisor implementation for stack HDP, version 2.2 was loaded
StackAdvisor implementation for stack HDP, version 2.3 was loaded
StackAdvisor implementation for stack HDP, version 2.4 was loaded
Returning HDP24StackAdvisor implementation
Error occured in stack advisor.
Error details: 'NoneType' object is not iterable
20 Apr 2016 16:03:56,917 INFO [qtp-ambari-client-2764] StackAdvisorRunner:71 - advisor script stderr: Traceback (most recent call last):
File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 158, in <module>
main(sys.argv)
File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 109, in main
result = stackAdvisor.recommendConfigurations(services, hosts)
File "/var/lib/ambari-server/resources/scripts/../stacks/stack_advisor.py", line 570, in recommendConfigurations
calculation(configurations, clusterSummary, services, hosts)
File "/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.0.6/services/stack_advisor.py", line 627, in recommendAmsConfigurations
if set(amsCollectorHosts).intersection(dn_hosts):
TypeError: 'NoneType' object is not iterable
20 Apr 2016 16:03:56,918 INFO [qtp-ambari-client-2764] AbstractResourceProvider:802 - Caught an exception while updating host components, retrying : org.apache.ambari.server.AmbariException: Stack Advisor reported an error: TypeError: 'NoneType' object is not iterable
StdOut file: /var/run/ambari-server/stack-recommendations/323/stackadvisor.out
StdErr file: /var/run/ambari-server/stack-recommendations/323/stackadvisor.err
```
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java dca81c5
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java 84f0bac
Diff: https://reviews.apache.org/r/46583/diff/
Testing
-------
Manually tested using the UI and BP.
# Local test results: PENDING
# Jenkins test results: PENDING
Thanks,
Robert Levas
Re: Review Request 46583: Stack Advisor issue when adding service to
Kerberized cluster
Posted by Aravindan Vijayan <av...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46583/#review130176
-----------------------------------------------------------
Ship it!
This looks like a general utility method. Can we check if something similar is not already present in StackAdvisorResourceProvider or somewhere else?
If there is no such method, we can go with this.
- Aravindan Vijayan
On April 22, 2016, 8:47 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46583/
> -----------------------------------------------------------
>
> (Updated April 22, 2016, 8:47 p.m.)
>
>
> Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, Oliver Szabo, and Sumit Mohanty.
>
>
> Bugs: AMBARI-16072
> https://issues.apache.org/jira/browse/AMBARI-16072
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When adding a service to a Kerberized cluster and click install nothing happens on the UI and i see the following error in the ambari server logs
>
> ```
> 20 Apr 2016 16:03:56,818 INFO [qtp-ambari-client-2764] KerberosHelperImpl:735 - Adding identity for JOURNALNODE to auth to local mapping
> 20 Apr 2016 16:03:56,818 INFO [qtp-ambari-client-2764] KerberosHelperImpl:735 - Adding identity for METRICS_COLLECTOR to auth to local mapping
> 20 Apr 2016 16:03:56,857 INFO [qtp-ambari-client-2764] StackAdvisorRunner:47 - Script=/var/lib/ambari-server/resources/scripts/stack_advisor.py, actionDirectory=/var/run/ambari-server/stack-recommendations/323, command=recommend-configurations
> 20 Apr 2016 16:03:56,860 INFO [qtp-ambari-client-2764] StackAdvisorRunner:61 - Stack-advisor output=/var/run/ambari-server/stack-recommendations/323/stackadvisor.out, error=/var/run/ambari-server/stack-recommendations/323/stackadvisor.err
> 20 Apr 2016 16:03:56,917 INFO [qtp-ambari-client-2764] StackAdvisorRunner:69 - Stack advisor output files
> 20 Apr 2016 16:03:56,917 INFO [qtp-ambari-client-2764] StackAdvisorRunner:70 - advisor script stdout: StackAdvisor implementation for stack HDP, version 2.0.6 was loaded
> StackAdvisor implementation for stack HDP, version 2.1 was loaded
> StackAdvisor implementation for stack HDP, version 2.2 was loaded
> StackAdvisor implementation for stack HDP, version 2.3 was loaded
> StackAdvisor implementation for stack HDP, version 2.4 was loaded
> Returning HDP24StackAdvisor implementation
> Error occured in stack advisor.
> Error details: 'NoneType' object is not iterable
> 20 Apr 2016 16:03:56,917 INFO [qtp-ambari-client-2764] StackAdvisorRunner:71 - advisor script stderr: Traceback (most recent call last):
> File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 158, in <module>
> main(sys.argv)
> File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 109, in main
> result = stackAdvisor.recommendConfigurations(services, hosts)
> File "/var/lib/ambari-server/resources/scripts/../stacks/stack_advisor.py", line 570, in recommendConfigurations
> calculation(configurations, clusterSummary, services, hosts)
> File "/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.0.6/services/stack_advisor.py", line 627, in recommendAmsConfigurations
> if set(amsCollectorHosts).intersection(dn_hosts):
> TypeError: 'NoneType' object is not iterable
> 20 Apr 2016 16:03:56,918 INFO [qtp-ambari-client-2764] AbstractResourceProvider:802 - Caught an exception while updating host components, retrying : org.apache.ambari.server.AmbariException: Stack Advisor reported an error: TypeError: 'NoneType' object is not iterable
> StdOut file: /var/run/ambari-server/stack-recommendations/323/stackadvisor.out
>
> StdErr file: /var/run/ambari-server/stack-recommendations/323/stackadvisor.err
> ```
>
> # Solution
> Pass to the stack advisor information about all installed services where each component is installed (component host map)
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java dca81c5
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java 84f0bac
>
> Diff: https://reviews.apache.org/r/46583/diff/
>
>
> Testing
> -------
>
> Manually tested using the UI and BP.
>
> # Local test results: PENDING
>
> # Jenkins test results: PENDING
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 46583: Stack Advisor issue when adding service to
Kerberized cluster
Posted by Robert Levas <rl...@hortonworks.com>.
> On April 22, 2016, 4:58 p.m., Aravindan Vijayan wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java, line 2433
> > <https://reviews.apache.org/r/46583/diff/1/?file=1357896#file1357896line2433>
> >
> > I meant this method.
>
> Robert Levas wrote:
> I did a bit of searching in the code and didn't see anything obvious. I search for methods the returned `Map<String, Set<String>>` and none seemd to return a map of components to host names given the cluster object. The closest method that resembles it is `org.apache.ambari.server.api.services.stackadvisor.StackAdvisorBlueprintProcessor#gatherComponentsHostsMap` but it builds the map using data from a Blueprint, not from the existing cluster data.
>
> I suppose I can move this method somewhere, but I am not sure where... maybe the Cluster object?
>
> Aravindan Vijayan wrote:
> I am ok with the method staying in this class.
After thinking about it... I'll move it.
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46583/#review130178
-----------------------------------------------------------
On April 22, 2016, 5:12 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46583/
> -----------------------------------------------------------
>
> (Updated April 22, 2016, 5:12 p.m.)
>
>
> Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, Oliver Szabo, Sumit Mohanty, and Srimanth Gunturi.
>
>
> Bugs: AMBARI-16072
> https://issues.apache.org/jira/browse/AMBARI-16072
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When adding a service to a Kerberized cluster and click install nothing happens on the UI and i see the following error in the ambari server logs
>
> ```
> 20 Apr 2016 16:03:56,818 INFO [qtp-ambari-client-2764] KerberosHelperImpl:735 - Adding identity for JOURNALNODE to auth to local mapping
> 20 Apr 2016 16:03:56,818 INFO [qtp-ambari-client-2764] KerberosHelperImpl:735 - Adding identity for METRICS_COLLECTOR to auth to local mapping
> 20 Apr 2016 16:03:56,857 INFO [qtp-ambari-client-2764] StackAdvisorRunner:47 - Script=/var/lib/ambari-server/resources/scripts/stack_advisor.py, actionDirectory=/var/run/ambari-server/stack-recommendations/323, command=recommend-configurations
> 20 Apr 2016 16:03:56,860 INFO [qtp-ambari-client-2764] StackAdvisorRunner:61 - Stack-advisor output=/var/run/ambari-server/stack-recommendations/323/stackadvisor.out, error=/var/run/ambari-server/stack-recommendations/323/stackadvisor.err
> 20 Apr 2016 16:03:56,917 INFO [qtp-ambari-client-2764] StackAdvisorRunner:69 - Stack advisor output files
> 20 Apr 2016 16:03:56,917 INFO [qtp-ambari-client-2764] StackAdvisorRunner:70 - advisor script stdout: StackAdvisor implementation for stack HDP, version 2.0.6 was loaded
> StackAdvisor implementation for stack HDP, version 2.1 was loaded
> StackAdvisor implementation for stack HDP, version 2.2 was loaded
> StackAdvisor implementation for stack HDP, version 2.3 was loaded
> StackAdvisor implementation for stack HDP, version 2.4 was loaded
> Returning HDP24StackAdvisor implementation
> Error occured in stack advisor.
> Error details: 'NoneType' object is not iterable
> 20 Apr 2016 16:03:56,917 INFO [qtp-ambari-client-2764] StackAdvisorRunner:71 - advisor script stderr: Traceback (most recent call last):
> File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 158, in <module>
> main(sys.argv)
> File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 109, in main
> result = stackAdvisor.recommendConfigurations(services, hosts)
> File "/var/lib/ambari-server/resources/scripts/../stacks/stack_advisor.py", line 570, in recommendConfigurations
> calculation(configurations, clusterSummary, services, hosts)
> File "/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.0.6/services/stack_advisor.py", line 627, in recommendAmsConfigurations
> if set(amsCollectorHosts).intersection(dn_hosts):
> TypeError: 'NoneType' object is not iterable
> 20 Apr 2016 16:03:56,918 INFO [qtp-ambari-client-2764] AbstractResourceProvider:802 - Caught an exception while updating host components, retrying : org.apache.ambari.server.AmbariException: Stack Advisor reported an error: TypeError: 'NoneType' object is not iterable
> StdOut file: /var/run/ambari-server/stack-recommendations/323/stackadvisor.out
>
> StdErr file: /var/run/ambari-server/stack-recommendations/323/stackadvisor.err
> ```
>
> # Solution
> Pass to the stack advisor information about all installed services where each component is installed (component host map)
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java dca81c5
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java 84f0bac
>
> Diff: https://reviews.apache.org/r/46583/diff/
>
>
> Testing
> -------
>
> Manually tested using the UI and BP.
>
> # Local test results: PENDING
>
> # Jenkins test results: PENDING
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 46583: Stack Advisor issue when adding service to
Kerberized cluster
Posted by Robert Levas <rl...@hortonworks.com>.
> On April 22, 2016, 4:58 p.m., Aravindan Vijayan wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java, line 2433
> > <https://reviews.apache.org/r/46583/diff/1/?file=1357896#file1357896line2433>
> >
> > I meant this method.
I did a bit of searching in the code and didn't see anything obvious. I search for methods the returned `Map<String, Set<String>>` and none seemd to return a map of components to host names given the cluster object. The closest method that resembles it is `org.apache.ambari.server.api.services.stackadvisor.StackAdvisorBlueprintProcessor#gatherComponentsHostsMap` but it builds the map using data from a Blueprint, not from the existing cluster data.
I suppose I can move this method somewhere, but I am not sure where... maybe the Cluster object?
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46583/#review130178
-----------------------------------------------------------
On April 22, 2016, 5:12 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46583/
> -----------------------------------------------------------
>
> (Updated April 22, 2016, 5:12 p.m.)
>
>
> Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, Oliver Szabo, Sumit Mohanty, and Srimanth Gunturi.
>
>
> Bugs: AMBARI-16072
> https://issues.apache.org/jira/browse/AMBARI-16072
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When adding a service to a Kerberized cluster and click install nothing happens on the UI and i see the following error in the ambari server logs
>
> ```
> 20 Apr 2016 16:03:56,818 INFO [qtp-ambari-client-2764] KerberosHelperImpl:735 - Adding identity for JOURNALNODE to auth to local mapping
> 20 Apr 2016 16:03:56,818 INFO [qtp-ambari-client-2764] KerberosHelperImpl:735 - Adding identity for METRICS_COLLECTOR to auth to local mapping
> 20 Apr 2016 16:03:56,857 INFO [qtp-ambari-client-2764] StackAdvisorRunner:47 - Script=/var/lib/ambari-server/resources/scripts/stack_advisor.py, actionDirectory=/var/run/ambari-server/stack-recommendations/323, command=recommend-configurations
> 20 Apr 2016 16:03:56,860 INFO [qtp-ambari-client-2764] StackAdvisorRunner:61 - Stack-advisor output=/var/run/ambari-server/stack-recommendations/323/stackadvisor.out, error=/var/run/ambari-server/stack-recommendations/323/stackadvisor.err
> 20 Apr 2016 16:03:56,917 INFO [qtp-ambari-client-2764] StackAdvisorRunner:69 - Stack advisor output files
> 20 Apr 2016 16:03:56,917 INFO [qtp-ambari-client-2764] StackAdvisorRunner:70 - advisor script stdout: StackAdvisor implementation for stack HDP, version 2.0.6 was loaded
> StackAdvisor implementation for stack HDP, version 2.1 was loaded
> StackAdvisor implementation for stack HDP, version 2.2 was loaded
> StackAdvisor implementation for stack HDP, version 2.3 was loaded
> StackAdvisor implementation for stack HDP, version 2.4 was loaded
> Returning HDP24StackAdvisor implementation
> Error occured in stack advisor.
> Error details: 'NoneType' object is not iterable
> 20 Apr 2016 16:03:56,917 INFO [qtp-ambari-client-2764] StackAdvisorRunner:71 - advisor script stderr: Traceback (most recent call last):
> File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 158, in <module>
> main(sys.argv)
> File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 109, in main
> result = stackAdvisor.recommendConfigurations(services, hosts)
> File "/var/lib/ambari-server/resources/scripts/../stacks/stack_advisor.py", line 570, in recommendConfigurations
> calculation(configurations, clusterSummary, services, hosts)
> File "/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.0.6/services/stack_advisor.py", line 627, in recommendAmsConfigurations
> if set(amsCollectorHosts).intersection(dn_hosts):
> TypeError: 'NoneType' object is not iterable
> 20 Apr 2016 16:03:56,918 INFO [qtp-ambari-client-2764] AbstractResourceProvider:802 - Caught an exception while updating host components, retrying : org.apache.ambari.server.AmbariException: Stack Advisor reported an error: TypeError: 'NoneType' object is not iterable
> StdOut file: /var/run/ambari-server/stack-recommendations/323/stackadvisor.out
>
> StdErr file: /var/run/ambari-server/stack-recommendations/323/stackadvisor.err
> ```
>
> # Solution
> Pass to the stack advisor information about all installed services where each component is installed (component host map)
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java dca81c5
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java 84f0bac
>
> Diff: https://reviews.apache.org/r/46583/diff/
>
>
> Testing
> -------
>
> Manually tested using the UI and BP.
>
> # Local test results: PENDING
>
> # Jenkins test results: PENDING
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 46583: Stack Advisor issue when adding service to
Kerberized cluster
Posted by Aravindan Vijayan <av...@hortonworks.com>.
> On April 22, 2016, 8:58 p.m., Aravindan Vijayan wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java, line 2433
> > <https://reviews.apache.org/r/46583/diff/1/?file=1357896#file1357896line2433>
> >
> > I meant this method.
>
> Robert Levas wrote:
> I did a bit of searching in the code and didn't see anything obvious. I search for methods the returned `Map<String, Set<String>>` and none seemd to return a map of components to host names given the cluster object. The closest method that resembles it is `org.apache.ambari.server.api.services.stackadvisor.StackAdvisorBlueprintProcessor#gatherComponentsHostsMap` but it builds the map using data from a Blueprint, not from the existing cluster data.
>
> I suppose I can move this method somewhere, but I am not sure where... maybe the Cluster object?
I am ok with the method staying in this class.
- Aravindan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46583/#review130178
-----------------------------------------------------------
On April 22, 2016, 9:12 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46583/
> -----------------------------------------------------------
>
> (Updated April 22, 2016, 9:12 p.m.)
>
>
> Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, Oliver Szabo, Sumit Mohanty, and Srimanth Gunturi.
>
>
> Bugs: AMBARI-16072
> https://issues.apache.org/jira/browse/AMBARI-16072
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When adding a service to a Kerberized cluster and click install nothing happens on the UI and i see the following error in the ambari server logs
>
> ```
> 20 Apr 2016 16:03:56,818 INFO [qtp-ambari-client-2764] KerberosHelperImpl:735 - Adding identity for JOURNALNODE to auth to local mapping
> 20 Apr 2016 16:03:56,818 INFO [qtp-ambari-client-2764] KerberosHelperImpl:735 - Adding identity for METRICS_COLLECTOR to auth to local mapping
> 20 Apr 2016 16:03:56,857 INFO [qtp-ambari-client-2764] StackAdvisorRunner:47 - Script=/var/lib/ambari-server/resources/scripts/stack_advisor.py, actionDirectory=/var/run/ambari-server/stack-recommendations/323, command=recommend-configurations
> 20 Apr 2016 16:03:56,860 INFO [qtp-ambari-client-2764] StackAdvisorRunner:61 - Stack-advisor output=/var/run/ambari-server/stack-recommendations/323/stackadvisor.out, error=/var/run/ambari-server/stack-recommendations/323/stackadvisor.err
> 20 Apr 2016 16:03:56,917 INFO [qtp-ambari-client-2764] StackAdvisorRunner:69 - Stack advisor output files
> 20 Apr 2016 16:03:56,917 INFO [qtp-ambari-client-2764] StackAdvisorRunner:70 - advisor script stdout: StackAdvisor implementation for stack HDP, version 2.0.6 was loaded
> StackAdvisor implementation for stack HDP, version 2.1 was loaded
> StackAdvisor implementation for stack HDP, version 2.2 was loaded
> StackAdvisor implementation for stack HDP, version 2.3 was loaded
> StackAdvisor implementation for stack HDP, version 2.4 was loaded
> Returning HDP24StackAdvisor implementation
> Error occured in stack advisor.
> Error details: 'NoneType' object is not iterable
> 20 Apr 2016 16:03:56,917 INFO [qtp-ambari-client-2764] StackAdvisorRunner:71 - advisor script stderr: Traceback (most recent call last):
> File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 158, in <module>
> main(sys.argv)
> File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 109, in main
> result = stackAdvisor.recommendConfigurations(services, hosts)
> File "/var/lib/ambari-server/resources/scripts/../stacks/stack_advisor.py", line 570, in recommendConfigurations
> calculation(configurations, clusterSummary, services, hosts)
> File "/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.0.6/services/stack_advisor.py", line 627, in recommendAmsConfigurations
> if set(amsCollectorHosts).intersection(dn_hosts):
> TypeError: 'NoneType' object is not iterable
> 20 Apr 2016 16:03:56,918 INFO [qtp-ambari-client-2764] AbstractResourceProvider:802 - Caught an exception while updating host components, retrying : org.apache.ambari.server.AmbariException: Stack Advisor reported an error: TypeError: 'NoneType' object is not iterable
> StdOut file: /var/run/ambari-server/stack-recommendations/323/stackadvisor.out
>
> StdErr file: /var/run/ambari-server/stack-recommendations/323/stackadvisor.err
> ```
>
> # Solution
> Pass to the stack advisor information about all installed services where each component is installed (component host map)
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java dca81c5
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java 84f0bac
>
> Diff: https://reviews.apache.org/r/46583/diff/
>
>
> Testing
> -------
>
> Manually tested using the UI and BP.
>
> # Local test results: PENDING
>
> # Jenkins test results: PENDING
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 46583: Stack Advisor issue when adding service to
Kerberized cluster
Posted by Aravindan Vijayan <av...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46583/#review130178
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java (line 2433)
<https://reviews.apache.org/r/46583/#comment193862>
I meant this method.
- Aravindan Vijayan
On April 22, 2016, 8:47 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46583/
> -----------------------------------------------------------
>
> (Updated April 22, 2016, 8:47 p.m.)
>
>
> Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, Oliver Szabo, and Sumit Mohanty.
>
>
> Bugs: AMBARI-16072
> https://issues.apache.org/jira/browse/AMBARI-16072
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When adding a service to a Kerberized cluster and click install nothing happens on the UI and i see the following error in the ambari server logs
>
> ```
> 20 Apr 2016 16:03:56,818 INFO [qtp-ambari-client-2764] KerberosHelperImpl:735 - Adding identity for JOURNALNODE to auth to local mapping
> 20 Apr 2016 16:03:56,818 INFO [qtp-ambari-client-2764] KerberosHelperImpl:735 - Adding identity for METRICS_COLLECTOR to auth to local mapping
> 20 Apr 2016 16:03:56,857 INFO [qtp-ambari-client-2764] StackAdvisorRunner:47 - Script=/var/lib/ambari-server/resources/scripts/stack_advisor.py, actionDirectory=/var/run/ambari-server/stack-recommendations/323, command=recommend-configurations
> 20 Apr 2016 16:03:56,860 INFO [qtp-ambari-client-2764] StackAdvisorRunner:61 - Stack-advisor output=/var/run/ambari-server/stack-recommendations/323/stackadvisor.out, error=/var/run/ambari-server/stack-recommendations/323/stackadvisor.err
> 20 Apr 2016 16:03:56,917 INFO [qtp-ambari-client-2764] StackAdvisorRunner:69 - Stack advisor output files
> 20 Apr 2016 16:03:56,917 INFO [qtp-ambari-client-2764] StackAdvisorRunner:70 - advisor script stdout: StackAdvisor implementation for stack HDP, version 2.0.6 was loaded
> StackAdvisor implementation for stack HDP, version 2.1 was loaded
> StackAdvisor implementation for stack HDP, version 2.2 was loaded
> StackAdvisor implementation for stack HDP, version 2.3 was loaded
> StackAdvisor implementation for stack HDP, version 2.4 was loaded
> Returning HDP24StackAdvisor implementation
> Error occured in stack advisor.
> Error details: 'NoneType' object is not iterable
> 20 Apr 2016 16:03:56,917 INFO [qtp-ambari-client-2764] StackAdvisorRunner:71 - advisor script stderr: Traceback (most recent call last):
> File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 158, in <module>
> main(sys.argv)
> File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 109, in main
> result = stackAdvisor.recommendConfigurations(services, hosts)
> File "/var/lib/ambari-server/resources/scripts/../stacks/stack_advisor.py", line 570, in recommendConfigurations
> calculation(configurations, clusterSummary, services, hosts)
> File "/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.0.6/services/stack_advisor.py", line 627, in recommendAmsConfigurations
> if set(amsCollectorHosts).intersection(dn_hosts):
> TypeError: 'NoneType' object is not iterable
> 20 Apr 2016 16:03:56,918 INFO [qtp-ambari-client-2764] AbstractResourceProvider:802 - Caught an exception while updating host components, retrying : org.apache.ambari.server.AmbariException: Stack Advisor reported an error: TypeError: 'NoneType' object is not iterable
> StdOut file: /var/run/ambari-server/stack-recommendations/323/stackadvisor.out
>
> StdErr file: /var/run/ambari-server/stack-recommendations/323/stackadvisor.err
> ```
>
> # Solution
> Pass to the stack advisor information about all installed services where each component is installed (component host map)
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java dca81c5
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java 84f0bac
>
> Diff: https://reviews.apache.org/r/46583/diff/
>
>
> Testing
> -------
>
> Manually tested using the UI and BP.
>
> # Local test results: PENDING
>
> # Jenkins test results: PENDING
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 46583: Stack Advisor issue when adding service to
Kerberized cluster
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46583/
-----------------------------------------------------------
(Updated April 22, 2016, 4:47 p.m.)
Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, Oliver Szabo, and Sumit Mohanty.
Bugs: AMBARI-16072
https://issues.apache.org/jira/browse/AMBARI-16072
Repository: ambari
Description
-------
When adding a service to a Kerberized cluster and click install nothing happens on the UI and i see the following error in the ambari server logs
```
20 Apr 2016 16:03:56,818 INFO [qtp-ambari-client-2764] KerberosHelperImpl:735 - Adding identity for JOURNALNODE to auth to local mapping
20 Apr 2016 16:03:56,818 INFO [qtp-ambari-client-2764] KerberosHelperImpl:735 - Adding identity for METRICS_COLLECTOR to auth to local mapping
20 Apr 2016 16:03:56,857 INFO [qtp-ambari-client-2764] StackAdvisorRunner:47 - Script=/var/lib/ambari-server/resources/scripts/stack_advisor.py, actionDirectory=/var/run/ambari-server/stack-recommendations/323, command=recommend-configurations
20 Apr 2016 16:03:56,860 INFO [qtp-ambari-client-2764] StackAdvisorRunner:61 - Stack-advisor output=/var/run/ambari-server/stack-recommendations/323/stackadvisor.out, error=/var/run/ambari-server/stack-recommendations/323/stackadvisor.err
20 Apr 2016 16:03:56,917 INFO [qtp-ambari-client-2764] StackAdvisorRunner:69 - Stack advisor output files
20 Apr 2016 16:03:56,917 INFO [qtp-ambari-client-2764] StackAdvisorRunner:70 - advisor script stdout: StackAdvisor implementation for stack HDP, version 2.0.6 was loaded
StackAdvisor implementation for stack HDP, version 2.1 was loaded
StackAdvisor implementation for stack HDP, version 2.2 was loaded
StackAdvisor implementation for stack HDP, version 2.3 was loaded
StackAdvisor implementation for stack HDP, version 2.4 was loaded
Returning HDP24StackAdvisor implementation
Error occured in stack advisor.
Error details: 'NoneType' object is not iterable
20 Apr 2016 16:03:56,917 INFO [qtp-ambari-client-2764] StackAdvisorRunner:71 - advisor script stderr: Traceback (most recent call last):
File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 158, in <module>
main(sys.argv)
File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 109, in main
result = stackAdvisor.recommendConfigurations(services, hosts)
File "/var/lib/ambari-server/resources/scripts/../stacks/stack_advisor.py", line 570, in recommendConfigurations
calculation(configurations, clusterSummary, services, hosts)
File "/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.0.6/services/stack_advisor.py", line 627, in recommendAmsConfigurations
if set(amsCollectorHosts).intersection(dn_hosts):
TypeError: 'NoneType' object is not iterable
20 Apr 2016 16:03:56,918 INFO [qtp-ambari-client-2764] AbstractResourceProvider:802 - Caught an exception while updating host components, retrying : org.apache.ambari.server.AmbariException: Stack Advisor reported an error: TypeError: 'NoneType' object is not iterable
StdOut file: /var/run/ambari-server/stack-recommendations/323/stackadvisor.out
StdErr file: /var/run/ambari-server/stack-recommendations/323/stackadvisor.err
```
# Solution
Pass to the stack advisor information about all installed services where each component is installed (component host map)
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java dca81c5
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java 84f0bac
Diff: https://reviews.apache.org/r/46583/diff/
Testing
-------
Manually tested using the UI and BP.
# Local test results: PENDING
# Jenkins test results: PENDING
Thanks,
Robert Levas
Re: Review Request 46583: Stack Advisor issue when adding service to
Kerberized cluster
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46583/
-----------------------------------------------------------
(Updated April 22, 2016, 4:46 p.m.)
Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, Oliver Szabo, and Sumit Mohanty.
Bugs: AMBARI-16079
https://issues.apache.org/jira/browse/AMBARI-16079
Repository: ambari
Description (updated)
-------
When adding a service to a Kerberized cluster and click install nothing happens on the UI and i see the following error in the ambari server logs
```
20 Apr 2016 16:03:56,818 INFO [qtp-ambari-client-2764] KerberosHelperImpl:735 - Adding identity for JOURNALNODE to auth to local mapping
20 Apr 2016 16:03:56,818 INFO [qtp-ambari-client-2764] KerberosHelperImpl:735 - Adding identity for METRICS_COLLECTOR to auth to local mapping
20 Apr 2016 16:03:56,857 INFO [qtp-ambari-client-2764] StackAdvisorRunner:47 - Script=/var/lib/ambari-server/resources/scripts/stack_advisor.py, actionDirectory=/var/run/ambari-server/stack-recommendations/323, command=recommend-configurations
20 Apr 2016 16:03:56,860 INFO [qtp-ambari-client-2764] StackAdvisorRunner:61 - Stack-advisor output=/var/run/ambari-server/stack-recommendations/323/stackadvisor.out, error=/var/run/ambari-server/stack-recommendations/323/stackadvisor.err
20 Apr 2016 16:03:56,917 INFO [qtp-ambari-client-2764] StackAdvisorRunner:69 - Stack advisor output files
20 Apr 2016 16:03:56,917 INFO [qtp-ambari-client-2764] StackAdvisorRunner:70 - advisor script stdout: StackAdvisor implementation for stack HDP, version 2.0.6 was loaded
StackAdvisor implementation for stack HDP, version 2.1 was loaded
StackAdvisor implementation for stack HDP, version 2.2 was loaded
StackAdvisor implementation for stack HDP, version 2.3 was loaded
StackAdvisor implementation for stack HDP, version 2.4 was loaded
Returning HDP24StackAdvisor implementation
Error occured in stack advisor.
Error details: 'NoneType' object is not iterable
20 Apr 2016 16:03:56,917 INFO [qtp-ambari-client-2764] StackAdvisorRunner:71 - advisor script stderr: Traceback (most recent call last):
File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 158, in <module>
main(sys.argv)
File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 109, in main
result = stackAdvisor.recommendConfigurations(services, hosts)
File "/var/lib/ambari-server/resources/scripts/../stacks/stack_advisor.py", line 570, in recommendConfigurations
calculation(configurations, clusterSummary, services, hosts)
File "/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.0.6/services/stack_advisor.py", line 627, in recommendAmsConfigurations
if set(amsCollectorHosts).intersection(dn_hosts):
TypeError: 'NoneType' object is not iterable
20 Apr 2016 16:03:56,918 INFO [qtp-ambari-client-2764] AbstractResourceProvider:802 - Caught an exception while updating host components, retrying : org.apache.ambari.server.AmbariException: Stack Advisor reported an error: TypeError: 'NoneType' object is not iterable
StdOut file: /var/run/ambari-server/stack-recommendations/323/stackadvisor.out
StdErr file: /var/run/ambari-server/stack-recommendations/323/stackadvisor.err
```
# Solution
Pass to the stack advisor information about all installed services where each component is installed (component host map)
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java dca81c5
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java 84f0bac
Diff: https://reviews.apache.org/r/46583/diff/
Testing
-------
Manually tested using the UI and BP.
# Local test results: PENDING
# Jenkins test results: PENDING
Thanks,
Robert Levas