You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org> on 2011/04/08 01:41:05 UTC

[jira] [Updated] (HBASE-3652) Speed up tests that enable/disable

     [ https://issues.apache.org/jira/browse/HBASE-3652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Daniel Cryans updated HBASE-3652:
--------------------------------------

    Attachment: HBASE-3652.patch

The main change in this patch is that I refactor the 1000ms sleep time out of Enable/Disable/DeleteTableHandler into EventHandler, and by doing that I had to change TestExecutorService to stop passing a null Server.

I also changed the sleep times that Todd pointed out to something equivalent that sleeps less time for more retries. By doing that I also had to change TestReplication to remove the line where it was setting it's own retries for the client.

> Speed up tests that enable/disable
> ----------------------------------
>
>                 Key: HBASE-3652
>                 URL: https://issues.apache.org/jira/browse/HBASE-3652
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.1
>            Reporter: Jean-Daniel Cryans
>            Priority: Critical
>             Fix For: 0.92.0
>
>         Attachments: HBASE-3652.patch
>
>
> While trying TestAdmin in the scope of HBASE-3650, I saw that it takes a lot more time to run than it used to. Upon inspection I see that there's 2 hardcoded 1 second sleeps in DisableTableHandler and EnableTableHandler in waitUntilDone (which is almost the same code in both cases too). Setting that down to 50ms dropped the run time in half... and I'm sure there's a few other sleeps that we could get rid of.
> I think that at least those 1sec should be configurable so that we can tune them down in the tests, but I wonder if we need them at all.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira