You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/09/27 13:31:30 UTC

[GitHub] [airflow] mrshu edited a comment on issue #5879: [AIRFLOW-5280] conn: Remove aws_default's default region name

mrshu edited a comment on issue #5879: [AIRFLOW-5280] conn: Remove aws_default's default region name
URL: https://github.com/apache/airflow/pull/5879#issuecomment-535940021
 
 
   @ashb It will not work in the sense that you will additionally need to specify either the `region_name` in the extra parameters (which the [docs](https://airflow.apache.org/howto/connection/aws.html#configuring-the-connection) mention) or set the `AWS_DEFAULT_REGION` environment variable.
   
   I would argue that the `aws_default` connection with "bare" install does not work for anyone who operates outside of the `us-east-1`. I realize it is special for historical reasons but with [22 regions](https://aws.amazon.com/about-aws/global-infrastructure/), I would wager that many will be hit by the unexpected behavior I described in the PR description: that you won't realize Airflow is silently using `us-east-1` as the default region without digging through the code.
   
   I firmly believe that explicit is better than implicit, especially in cases of default configuration. Hence, I see it more as fixing a small bug than changing some already-established behavior.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services