[jira] [Updated] (YARN-359) NodeManager container-related tests fail on branch-trunk-win

["Chris Nauroth (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/YARN-359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Nauroth updated YARN-359:
-------------------------------

    Attachment: YARN-359-branch-trunk-win.2.patch

Vinod, thank you for the review.

{quote}
If I follow correctly, YARN-233 moved isSetsidSupported() from ContainerExecutor to shell and now this patch moves it back.
{quote}

Yes, that's correct.

{quote}
I think we should move the newly added methods in shell - getRunCommand(), getCheckProcessIsAliveCommand() and getSignalKillCommand() - into ContainerExecutor.
{quote}

I'm uploading a new patch that does this.

                
> NodeManager container-related tests fail on branch-trunk-win
> ------------------------------------------------------------
>
>                 Key: YARN-359
>                 URL: https://issues.apache.org/jira/browse/YARN-359
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: trunk-win
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: YARN-359-branch-trunk-win.1.patch, YARN-359-branch-trunk-win.2.patch
>
>
> On branch-trunk-win, there are test failures in {{TestContainerManager}}, {{TestNodeManagerShutdown}}, {{TestContainerLaunch}}, and {{TestContainersMonitor}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira