[jira] (MCHANGES-305) Provide support for private Github repos

["Olivier Lamy (JIRA)" <ji...@codehaus.org>]

    [ https://jira.codehaus.org/browse/MCHANGES-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=323031#comment-323031 ] 

Olivier Lamy commented on MCHANGES-305:
---------------------------------------

doesn't build anymore with your patch:
{code}
INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
[ERROR] /Users/olamy/dev/sources/maven/maven-plugins/maven-changes-plugin/src/main/java/org/apache/maven/plugin/announcement/AnnouncementMojo.java:[792,17] cannot find symbol
symbol  : constructor GitHubDownloader(org.apache.maven.project.MavenProject,java.lang.String,int,boolean,boolean)
location: class org.apache.maven.plugin.github.GitHubDownloader
{code}
I would prefer to prefer backward compat for GitHubDownloader (and that will fix this issue :-) ).
BTW in case of github enterprise you don't set credentials ? 
                
> Provide support for private Github repos
> ----------------------------------------
>
>                 Key: MCHANGES-305
>                 URL: https://jira.codehaus.org/browse/MCHANGES-305
>             Project: Maven 2.x Changes Plugin
>          Issue Type: Improvement
>          Components: github
>            Reporter: Erik Billerby
>         Attachments: github-credentials.diff, github-credentials-update.patch
>
>
> The egit-github client provides support for both basic authentication and oauth. It should be pretty easy to implement in the github issue downloader. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira