You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "epugh (via GitHub)" <gi...@apache.org> on 2023/04/14 19:49:27 UTC
[GitHub] [solr] epugh opened a new pull request, #1564: SOLR-16601: remove deprecated code in Solr Clients
epugh opened a new pull request, #1564:
URL: https://github.com/apache/solr/pull/1564
https://issues.apache.org/jira/browse/SOLR-16601
# Description
Found more deprecated code that should be removed from `main`
# Solution
Remove
# Tests
ran
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] stillalex commented on a diff in pull request #1564: SOLR-16601: remove deprecated code in Solr Clients
Posted by "stillalex (via GitHub)" <gi...@apache.org>.
stillalex commented on code in PR #1564:
URL: https://github.com/apache/solr/pull/1564#discussion_r1175655353
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##########
@@ -1290,20 +1240,6 @@ public ResponseParser getParser() {
return parser;
}
- /**
- * Note: This setter method is <b>not thread-safe</b>.
- *
- * @param parser Default Response Parser chosen to parse the response if the parser were not
- * specified as part of the request.
- * @see org.apache.solr.client.solrj.SolrRequest#getResponseParser()
- * @deprecated use {@link Http2SolrClient.Builder#withResponseParser(ResponseParser)} instead
- */
- @Deprecated
- public void setParser(ResponseParser parser) {
- this.parser = parser;
- updateDefaultMimeTypeForParser();
Review Comment:
opened https://github.com/apache/solr/pull/1587 with a fix for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh merged pull request #1564: SOLR-16601: remove deprecated code in Solr Clients
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh merged PR #1564:
URL: https://github.com/apache/solr/pull/1564
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] stillalex commented on a diff in pull request #1564: SOLR-16601: remove deprecated code in Solr Clients
Posted by "stillalex (via GitHub)" <gi...@apache.org>.
stillalex commented on code in PR #1564:
URL: https://github.com/apache/solr/pull/1564#discussion_r1174077500
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##########
@@ -1290,20 +1240,6 @@ public ResponseParser getParser() {
return parser;
}
- /**
- * Note: This setter method is <b>not thread-safe</b>.
- *
- * @param parser Default Response Parser chosen to parse the response if the parser were not
- * specified as part of the request.
- * @see org.apache.solr.client.solrj.SolrRequest#getResponseParser()
- * @deprecated use {@link Http2SolrClient.Builder#withResponseParser(ResponseParser)} instead
- */
- @Deprecated
- public void setParser(ResponseParser parser) {
- this.parser = parser;
- updateDefaultMimeTypeForParser();
Review Comment:
@epugh this breaks update of default mime types functionality. code needs to go via the setter when updating the parser so `updateDefaultMimeTypeForParser` is always called otherwise that set becomes stale, I am working on a patch for SOLR-16737 and will add it back. fyi @tflobbe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org