You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/08/27 00:38:35 UTC
[GitHub] [fineract] Cadreia opened a new pull request #1842: Bulk import feature
Cadreia opened a new pull request #1842:
URL: https://github.com/apache/fineract/pull/1842
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1842: Bulk import feature (FINERACT-1396)
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1842:
URL: https://github.com/apache/fineract/pull/1842#issuecomment-926985652
Hi - is this ready for review, or still work in progress?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1842: Bulk import feature (FINERACT-1396)
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1842:
URL: https://github.com/apache/fineract/pull/1842#issuecomment-939196606
Apologies @BLasan - did not notice you were going to review this as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan commented on pull request #1842: Bulk import feature (FINERACT-1396)
Posted by GitBox <gi...@apache.org>.
BLasan commented on pull request #1842:
URL: https://github.com/apache/fineract/pull/1842#issuecomment-938489033
> @bharathc27 , @francisguchie , will you like to functionally test this and let us know if its ready to be merged?
>
> @BLasan will you like to also review this? Also watch how @ptuomola does code reviews so you can learn.
Will start reviewing today
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1842: Bulk import feature
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1842:
URL: https://github.com/apache/fineract/pull/1842#issuecomment-908631201
Thanks for contributing to Apache Fineract @Cadreia . What issue is this PR fixing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1842: Bulk import feature (FINERACT-1396)
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1842:
URL: https://github.com/apache/fineract/pull/1842#issuecomment-938453783
@bharathc27 , @francisguchie , will you like to functionally test this and let us know if its ready to be merged?
@BLasan will you like to also review this? Also watch how @ptuomola does code reviews so you can learn.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola merged pull request #1842: Bulk import feature (FINERACT-1396)
Posted by GitBox <gi...@apache.org>.
ptuomola merged pull request #1842:
URL: https://github.com/apache/fineract/pull/1842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1842: Bulk import feature
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1842:
URL: https://github.com/apache/fineract/pull/1842#issuecomment-908631201
Thanks for contributing to Apache Fineract @Cadreia . What issue is this PR fixing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] Cadreia commented on pull request #1842: Bulk import feature (FINERACT-1396)
Posted by GitBox <gi...@apache.org>.
Cadreia commented on pull request #1842:
URL: https://github.com/apache/fineract/pull/1842#issuecomment-927023276
It's still WIP. Will submit for review once I'm done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1842: Bulk import feature (FINERACT-1396)
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1842:
URL: https://github.com/apache/fineract/pull/1842#issuecomment-939196708
Looked OK to me - the only thing I was going to comment on was the commented out code - this should have been cleaned up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org