You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Jason Gustafson <ja...@confluent.io> on 2019/04/08 15:55:16 UTC

[VOTE] KIP-360: Improve handling of unknown producer when using EOS

Hi All,

I'd like to start a vote on KIP-360:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-360%3A+Improve+handling+of+unknown+producer
.

+1 from me (duh)

Thanks,
Jason

Re: [VOTE] KIP-360: Improve handling of unknown producer when using EOS

Posted by Jason Gustafson <ja...@confluent.io>.
Thanks Matthias. With that, I can close this vote. The total is +4 with 3
binding votes.

-Jason

On Wed, Aug 21, 2019 at 3:52 PM Matthias J. Sax <ma...@confluent.io>
wrote:

> +1 (binding)
>
> On 4/10/19 12:17 AM, Magnus Edenhill wrote:
> > +1 (non-binding)
> >
> >
> > Den ons 10 apr. 2019 kl 02:38 skrev Guozhang Wang <wa...@gmail.com>:
> >
> >> +1 (binding). Thanks for the written KIP! The approach lgtm.
> >>
> >> One minor thing: the name of "last epoch" maybe a bit misleading
> (although
> >> it is for internal usage only and will not be exposed to users) for
> future
> >> developers, how about rename it to "required_epoch" and if it is set to
> >> "-1" it means "not required, hence not checks"?
> >>
> >> Guozhang
> >>
> >> On Tue, Apr 9, 2019 at 5:02 PM Jason Gustafson <ja...@confluent.io>
> wrote:
> >>
> >>> Bump (for Guozhang)
> >>>
> >>> On Mon, Apr 8, 2019 at 8:55 AM Jason Gustafson <ja...@confluent.io>
> >> wrote:
> >>>
> >>>> Hi All,
> >>>>
> >>>> I'd like to start a vote on KIP-360:
> >>>>
> >>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-360%3A+Improve+handling+of+unknown+producer
> >>>> .
> >>>>
> >>>> +1 from me (duh)
> >>>>
> >>>> Thanks,
> >>>> Jason
> >>>>
> >>>
> >>
> >> --
> >> -- Guozhang
> >>
> >
>
>

Re: [VOTE] KIP-360: Improve handling of unknown producer when using EOS

Posted by "Matthias J. Sax" <ma...@confluent.io>.
+1 (binding)

On 4/10/19 12:17 AM, Magnus Edenhill wrote:
> +1 (non-binding)
> 
> 
> Den ons 10 apr. 2019 kl 02:38 skrev Guozhang Wang <wa...@gmail.com>:
> 
>> +1 (binding). Thanks for the written KIP! The approach lgtm.
>>
>> One minor thing: the name of "last epoch" maybe a bit misleading (although
>> it is for internal usage only and will not be exposed to users) for future
>> developers, how about rename it to "required_epoch" and if it is set to
>> "-1" it means "not required, hence not checks"?
>>
>> Guozhang
>>
>> On Tue, Apr 9, 2019 at 5:02 PM Jason Gustafson <ja...@confluent.io> wrote:
>>
>>> Bump (for Guozhang)
>>>
>>> On Mon, Apr 8, 2019 at 8:55 AM Jason Gustafson <ja...@confluent.io>
>> wrote:
>>>
>>>> Hi All,
>>>>
>>>> I'd like to start a vote on KIP-360:
>>>>
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-360%3A+Improve+handling+of+unknown+producer
>>>> .
>>>>
>>>> +1 from me (duh)
>>>>
>>>> Thanks,
>>>> Jason
>>>>
>>>
>>
>> --
>> -- Guozhang
>>
> 


Re: [VOTE] KIP-360: Improve handling of unknown producer when using EOS

Posted by Magnus Edenhill <ma...@edenhill.se>.
+1 (non-binding)


Den ons 10 apr. 2019 kl 02:38 skrev Guozhang Wang <wa...@gmail.com>:

> +1 (binding). Thanks for the written KIP! The approach lgtm.
>
> One minor thing: the name of "last epoch" maybe a bit misleading (although
> it is for internal usage only and will not be exposed to users) for future
> developers, how about rename it to "required_epoch" and if it is set to
> "-1" it means "not required, hence not checks"?
>
> Guozhang
>
> On Tue, Apr 9, 2019 at 5:02 PM Jason Gustafson <ja...@confluent.io> wrote:
>
> > Bump (for Guozhang)
> >
> > On Mon, Apr 8, 2019 at 8:55 AM Jason Gustafson <ja...@confluent.io>
> wrote:
> >
> >> Hi All,
> >>
> >> I'd like to start a vote on KIP-360:
> >>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-360%3A+Improve+handling+of+unknown+producer
> >> .
> >>
> >> +1 from me (duh)
> >>
> >> Thanks,
> >> Jason
> >>
> >
>
> --
> -- Guozhang
>

Re: [VOTE] KIP-360: Improve handling of unknown producer when using EOS

Posted by Guozhang Wang <wa...@gmail.com>.
+1 (binding). Thanks for the written KIP! The approach lgtm.

One minor thing: the name of "last epoch" maybe a bit misleading (although
it is for internal usage only and will not be exposed to users) for future
developers, how about rename it to "required_epoch" and if it is set to
"-1" it means "not required, hence not checks"?

Guozhang

On Tue, Apr 9, 2019 at 5:02 PM Jason Gustafson <ja...@confluent.io> wrote:

> Bump (for Guozhang)
>
> On Mon, Apr 8, 2019 at 8:55 AM Jason Gustafson <ja...@confluent.io> wrote:
>
>> Hi All,
>>
>> I'd like to start a vote on KIP-360:
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-360%3A+Improve+handling+of+unknown+producer
>> .
>>
>> +1 from me (duh)
>>
>> Thanks,
>> Jason
>>
>

-- 
-- Guozhang

Re: [VOTE] KIP-360: Improve handling of unknown producer when using EOS

Posted by Jason Gustafson <ja...@confluent.io>.
Bump (for Guozhang)

On Mon, Apr 8, 2019 at 8:55 AM Jason Gustafson <ja...@confluent.io> wrote:

> Hi All,
>
> I'd like to start a vote on KIP-360:
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-360%3A+Improve+handling+of+unknown+producer
> .
>
> +1 from me (duh)
>
> Thanks,
> Jason
>