You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/11/18 07:28:16 UTC
[GitHub] [cloudstack] Spaceman1984 opened a new pull request #4476: Removed sensitive info from UI when attach/detach fails
Spaceman1984 opened a new pull request #4476:
URL: https://github.com/apache/cloudstack/pull/4476
### Description
This PR...
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
Fixes: #4419
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [x] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
This was tested by creating a volume, attaching it to a running instance, and detaching the volume.
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4476: Removed sensitive info from UI when volume attach/detach fails
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4476:
URL: https://github.com/apache/cloudstack/pull/4476#issuecomment-730013899
Travis lgtm, let's merge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 removed a comment on pull request #4476: Removed sensitive info from UI when volume attach/detach fails
Posted by GitBox <gi...@apache.org>.
Spaceman1984 removed a comment on pull request #4476:
URL: https://github.com/apache/cloudstack/pull/4476#issuecomment-729545755
@blueorangutan test matrix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on pull request #4476: Removed sensitive info from UI when volume attach/detach fails
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4476:
URL: https://github.com/apache/cloudstack/pull/4476#issuecomment-729543495
@DaanHoogland, without having time to test, I trust your Java skills đź‘Ť
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4476: Removed sensitive info from UI when volume attach/detach fails
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4476:
URL: https://github.com/apache/cloudstack/pull/4476#issuecomment-729506797
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2395
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4476: Removed sensitive info from UI when volume attach/detach fails
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4476:
URL: https://github.com/apache/cloudstack/pull/4476#issuecomment-729622028
only tesxtual change in output. travis failure seems a maven central/travis issue. We get a lot of those lately. I sugest we merge this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4476: Removed sensitive info from UI when attach/detach fails
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4476:
URL: https://github.com/apache/cloudstack/pull/4476#issuecomment-729492066
@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #4476: Removed sensitive info from UI when volume attach/detach fails
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #4476:
URL: https://github.com/apache/cloudstack/pull/4476#issuecomment-729545755
@blueorangutan test matrix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4476: Removed sensitive info from UI when volume attach/detach fails
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4476:
URL: https://github.com/apache/cloudstack/pull/4476
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #4476: Removed sensitive info from UI when attach/detach fails
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #4476:
URL: https://github.com/apache/cloudstack/pull/4476#issuecomment-729491820
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 closed pull request #4476: Removed sensitive info from UI when volume attach/detach fails
Posted by GitBox <gi...@apache.org>.
Spaceman1984 closed pull request #4476:
URL: https://github.com/apache/cloudstack/pull/4476
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4476: Removed sensitive info from UI when volume attach/detach fails
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4476:
URL: https://github.com/apache/cloudstack/pull/4476#issuecomment-729504620
@andrijapanicsb please review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org