[GitHub] [incubator-kyuubi] simon824 commented on a change in pull request #1298: [KYUUBI #1294] Refactor test suite about RESTful APIs to keep the unified Scala test style

[GitBox <gi...@apache.org>]

simon824 commented on a change in pull request #1298:
URL: https://github.com/apache/incubator-kyuubi/pull/1298#discussion_r737433313



##########
File path: kyuubi-server/src/test/scala/org/apache/kyuubi/server/RestFrontendServiceSuite.scala
##########
@@ -119,27 +126,26 @@ class RestApiBaseSuite extends JerseyTest {
   }
 
   override def getTestContainerFactory: TestContainerFactory = new JettyTestContainerFactory
-
 }
 
-class RestErrorAndExceptionSuite extends RestApiBaseSuite {
+class RestErrorAndExceptionSuite extends KyuubiFunSuite {
 
-  @Test
-  def testErrorAndExceptionResponse: Unit = {
+  test("test error and exception response") {
     withKyuubiRestServer {
-      (_, _, _) =>
+      (_, host, port, client) =>
+
         // send a not exists request
-        var response = target("api/v1/pong").request().get()
+        var response = client.target(s"http://$host:$port/api/v1/pong").request().get()

Review comment:
       Yes, this client needs absolute url.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org