You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/22 16:23:51 UTC

[GitHub] [spark] lw33 opened a new pull request #35938: [SPARK-38624][SQL] Reduce UnsafeProjection.create call times when Percentile function serializes the aggregation buffer object.

lw33 opened a new pull request #35938:
URL: https://github.com/apache/spark/pull/35938


   ## What changes were proposed in this pull request?
   Percentile serialize method does not call UnsafeProjection.create.
   UnsafeProjection as a field for Percentile.
   
   ## Why are the changes needed?
   It doesn't have to call UnsafeProjection.create every time.
   
   ## Does this PR introduce any user-facing change?
   No.
   
   ## How was this patch tested?
   Unit Test
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] wangyum closed pull request #35938: [SPARK-38624][SQL] Reduce UnsafeProjection.create call times when Percentile function serializes the aggregation buffer object.

Posted by GitBox <gi...@apache.org>.
wangyum closed pull request #35938:
URL: https://github.com/apache/spark/pull/35938


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #35938: [SPARK-38624][SQL] Reduce UnsafeProjection.create call times when Percentile function serializes the aggregation buffer object.

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35938:
URL: https://github.com/apache/spark/pull/35938#issuecomment-1075953386


   Should wait for the test results.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] wangyum commented on pull request #35938: [SPARK-38624][SQL] Reduce UnsafeProjection.create call times when Percentile function serializes the aggregation buffer object.

Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #35938:
URL: https://github.com/apache/spark/pull/35938#issuecomment-1076120276


   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #35938: [SPARK-38624][SQL] Reduce UnsafeProjection.create call times when Percentile function serializes the aggregation buffer object.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #35938:
URL: https://github.com/apache/spark/pull/35938#issuecomment-1075923444


   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] wangyum commented on pull request #35938: [SPARK-38624][SQL] Reduce UnsafeProjection.create call times when Percentile function serializes the aggregation buffer object.

Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #35938:
URL: https://github.com/apache/spark/pull/35938#issuecomment-1075783754


   @lw33 Could you enable the GitHub Actions in your forked repository: https://github.com/apache/spark/pull/35938/checks?check_run_id=5647252609


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org