[GitHub] [httpcomponents-client] ok2c commented on a change in pull request #140: HTTPCLIENT-1969: Filter out weak cipher suites

[GitBox <gi...@apache.org>]

ok2c commented on a change in pull request #140: HTTPCLIENT-1969: Filter out weak cipher suites
URL: https://github.com/apache/httpcomponents-client/pull/140#discussion_r262143956
 
 

 ##########
 File path: httpclient/src/main/java/org/apache/http/conn/ssl/SSLConnectionSocketFactory.java
 ##########
 @@ -183,6 +193,16 @@ public static SSLConnectionSocketFactory getSocketFactory() throws SSLInitializa
         return new SSLConnectionSocketFactory(SSLContexts.createDefault(), getDefaultHostnameVerifier());
     }
 
+    static boolean isWeakCipherSuite(final String cipherSuite) {
+        final String normalizedCipherSuite = cipherSuite.toUpperCase();
 
 Review comment:
   @artem-smotrakov Please use `#toUpperCase` with  `Locale#ROOT` parameter. Alternatively you might want to use non-case sensitive regex matching now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org