You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@openmeetings.apache.org by so...@apache.org on 2012/02/23 13:39:24 UTC
svn commit: r1292765 -
/incubator/openmeetings/trunk/singlewebapp/WebContent/src/plugins/conference/whiteboard/fixedFileExplorerWhiteboardPanel.lzx
Author: solomax
Date: Thu Feb 23 12:39:23 2012
New Revision: 1292765
URL: http://svn.apache.org/viewvc?rev=1292765&view=rev
Log:
Whiteboard room index is displayed instead of id
Modified:
incubator/openmeetings/trunk/singlewebapp/WebContent/src/plugins/conference/whiteboard/fixedFileExplorerWhiteboardPanel.lzx
Modified: incubator/openmeetings/trunk/singlewebapp/WebContent/src/plugins/conference/whiteboard/fixedFileExplorerWhiteboardPanel.lzx
URL: http://svn.apache.org/viewvc/incubator/openmeetings/trunk/singlewebapp/WebContent/src/plugins/conference/whiteboard/fixedFileExplorerWhiteboardPanel.lzx?rev=1292765&r1=1292764&r2=1292765&view=diff
==============================================================================
--- incubator/openmeetings/trunk/singlewebapp/WebContent/src/plugins/conference/whiteboard/fixedFileExplorerWhiteboardPanel.lzx (original)
+++ incubator/openmeetings/trunk/singlewebapp/WebContent/src/plugins/conference/whiteboard/fixedFileExplorerWhiteboardPanel.lzx Thu Feb 23 12:39:23 2012
@@ -78,7 +78,7 @@
<class name="fixedFileExplorerWhiteboardPanel" extends="basePropertyPanelWhiteboard"
labelid="615" visible="${((canvas.currentRoomObj.hideWhiteboard) ? false:true)}">
-
+ <attribute name="whiteboardCount" value="0" type="number" />
<!--
-->
@@ -128,11 +128,13 @@
});
var tempWidth = this._bar.getCurrentSize();
+ var whiteboardName = canvas.getLabelName(615) + (whiteboardCount > 0 ? " " + whiteboardCount : "");
+ whiteboardCount++;
var tWhiteboardBtn = new lz.whiteboardMiniButton(this._bar,{
objRef:whiteboard,
width:tempWidth,
isactive:true,
- btnName:canvas.getLabelName(615)+" "+whiteboardId
+ btnName: whiteboardName
});
this._bar.currentBtn = tWhiteboardBtn;
Re: svn commit: r1292765 - /incubator/openmeetings/trunk/singlewebapp/WebContent/src/plugins/conference/whiteboard/fixedFileExplorerWhiteboardPanel.lzx
Posted by Maxim Solodovnik <so...@gmail.com>.
The number displayed to the user has nothing in common with whiteboard id
It's just client specific index.
If 2 clients will add whiteboard, it will not affect server id anyhow.
In fact it is possible that clients will have different whiteboard order,
but I doubt it.
On Thu, Feb 23, 2012 at 19:46, seba.wagner@gmail.com
<se...@gmail.com>wrote:
> Hi Maxim,
>
> did you check if the name of the whiteboard is the same on all screens of
> all participants? You cannot count this whiteboard Id client-side only from
> my point of view, it has to be count on server side, and eventually it
> should be "cleaned" or reseted to 0 if all whiteboards are deleted.
> Otherwise if client side counted it might also happen that two users click
> "add whiteboard" at the same moment, they will receive the same id if you
> just count the available tabs on the client so far.
>
> Sebastian
>
> 2012/2/23 <so...@apache.org>
>
>> Author: solomax
>> Date: Thu Feb 23 12:39:23 2012
>> New Revision: 1292765
>>
>> URL: http://svn.apache.org/viewvc?rev=1292765&view=rev
>> Log:
>> Whiteboard room index is displayed instead of id
>>
>> Modified:
>>
>> incubator/openmeetings/trunk/singlewebapp/WebContent/src/plugins/conference/whiteboard/fixedFileExplorerWhiteboardPanel.lzx
>>
>> Modified:
>> incubator/openmeetings/trunk/singlewebapp/WebContent/src/plugins/conference/whiteboard/fixedFileExplorerWhiteboardPanel.lzx
>> URL:
>> http://svn.apache.org/viewvc/incubator/openmeetings/trunk/singlewebapp/WebContent/src/plugins/conference/whiteboard/fixedFileExplorerWhiteboardPanel.lzx?rev=1292765&r1=1292764&r2=1292765&view=diff
>>
>> ==============================================================================
>> ---
>> incubator/openmeetings/trunk/singlewebapp/WebContent/src/plugins/conference/whiteboard/fixedFileExplorerWhiteboardPanel.lzx
>> (original)
>> +++
>> incubator/openmeetings/trunk/singlewebapp/WebContent/src/plugins/conference/whiteboard/fixedFileExplorerWhiteboardPanel.lzx
>> Thu Feb 23 12:39:23 2012
>> @@ -78,7 +78,7 @@
>>
>> <class name="fixedFileExplorerWhiteboardPanel"
>> extends="basePropertyPanelWhiteboard"
>> labelid="615"
>> visible="${((canvas.currentRoomObj.hideWhiteboard) ? false:true)}">
>> -
>> + <attribute name="whiteboardCount" value="0" type="number" />
>> <!--
>>
>> -->
>> @@ -128,11 +128,13 @@
>> });
>> var tempWidth = this._bar.getCurrentSize();
>>
>> + var whiteboardName = canvas.getLabelName(615) + (whiteboardCount
>> > 0 ? " " + whiteboardCount : "");
>> + whiteboardCount++;
>> var tWhiteboardBtn = new lz.whiteboardMiniButton(this._bar,{
>> objRef:whiteboard,
>> width:tempWidth,
>> isactive:true,
>> - btnName:canvas.getLabelName(615)+"
>> "+whiteboardId
>> + btnName: whiteboardName
>> });
>>
>> this._bar.currentBtn = tWhiteboardBtn;
>>
>>
>>
>
>
> --
> Sebastian Wagner
> http://www.openmeetings.de
> http://incubator.apache.org/openmeetings/
> http://www.webbase-design.de
> http://www.wagner-sebastian.com
> seba.wagner@gmail.com
>
--
WBR
Maxim aka solomax
Re: svn commit: r1292765 - /incubator/openmeetings/trunk/singlewebapp/WebContent/src/plugins/conference/whiteboard/fixedFileExplorerWhiteboardPanel.lzx
Posted by "seba.wagner@gmail.com" <se...@gmail.com>.
Hi Maxim,
did you check if the name of the whiteboard is the same on all screens of
all participants? You cannot count this whiteboard Id client-side only from
my point of view, it has to be count on server side, and eventually it
should be "cleaned" or reseted to 0 if all whiteboards are deleted.
Otherwise if client side counted it might also happen that two users click
"add whiteboard" at the same moment, they will receive the same id if you
just count the available tabs on the client so far.
Sebastian
2012/2/23 <so...@apache.org>
> Author: solomax
> Date: Thu Feb 23 12:39:23 2012
> New Revision: 1292765
>
> URL: http://svn.apache.org/viewvc?rev=1292765&view=rev
> Log:
> Whiteboard room index is displayed instead of id
>
> Modified:
>
> incubator/openmeetings/trunk/singlewebapp/WebContent/src/plugins/conference/whiteboard/fixedFileExplorerWhiteboardPanel.lzx
>
> Modified:
> incubator/openmeetings/trunk/singlewebapp/WebContent/src/plugins/conference/whiteboard/fixedFileExplorerWhiteboardPanel.lzx
> URL:
> http://svn.apache.org/viewvc/incubator/openmeetings/trunk/singlewebapp/WebContent/src/plugins/conference/whiteboard/fixedFileExplorerWhiteboardPanel.lzx?rev=1292765&r1=1292764&r2=1292765&view=diff
>
> ==============================================================================
> ---
> incubator/openmeetings/trunk/singlewebapp/WebContent/src/plugins/conference/whiteboard/fixedFileExplorerWhiteboardPanel.lzx
> (original)
> +++
> incubator/openmeetings/trunk/singlewebapp/WebContent/src/plugins/conference/whiteboard/fixedFileExplorerWhiteboardPanel.lzx
> Thu Feb 23 12:39:23 2012
> @@ -78,7 +78,7 @@
>
> <class name="fixedFileExplorerWhiteboardPanel"
> extends="basePropertyPanelWhiteboard"
> labelid="615" visible="${((canvas.currentRoomObj.hideWhiteboard)
> ? false:true)}">
> -
> + <attribute name="whiteboardCount" value="0" type="number" />
> <!--
>
> -->
> @@ -128,11 +128,13 @@
> });
> var tempWidth = this._bar.getCurrentSize();
>
> + var whiteboardName = canvas.getLabelName(615) + (whiteboardCount >
> 0 ? " " + whiteboardCount : "");
> + whiteboardCount++;
> var tWhiteboardBtn = new lz.whiteboardMiniButton(this._bar,{
> objRef:whiteboard,
> width:tempWidth,
> isactive:true,
> - btnName:canvas.getLabelName(615)+"
> "+whiteboardId
> + btnName: whiteboardName
> });
>
> this._bar.currentBtn = tWhiteboardBtn;
>
>
>
--
Sebastian Wagner
http://www.openmeetings.de
http://incubator.apache.org/openmeetings/
http://www.webbase-design.de
http://www.wagner-sebastian.com
seba.wagner@gmail.com