You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by rxin <gi...@git.apache.org> on 2016/06/24 22:56:59 UTC

[GitHub] spark pull request #13901: [SPARK-16199][SQL] Add a method to list the refer...

GitHub user rxin opened a pull request:

    https://github.com/apache/spark/pull/13901

    [SPARK-16199][SQL] Add a method to list the referenced columns in data source Filter

    ## What changes were proposed in this pull request?
    It would be useful to support listing the columns that are referenced by a filter. This can help simplify data source code.
    
    ## How was this patch tested?
    N/A

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rxin/spark SPARK-16199

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/13901.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #13901
    
----
commit 846c0e4ddec35352b07c9a4f72769bcceecfa25e
Author: Reynold Xin <rx...@databricks.com>
Date:   2016-06-24T22:55:35Z

    [SPARK-16199][SQL] Add a method to list the referenced columns in data source Filter

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #13901: [SPARK-16199][SQL] Add a method to list the referenced c...

Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/13901
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #13901: [SPARK-16199][SQL] Add a method to list the referenced c...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/13901
  
    **[Test build #61209 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61209/consoleFull)** for PR 13901 at commit [`846c0e4`](https://github.com/apache/spark/commit/846c0e4ddec35352b07c9a4f72769bcceecfa25e).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #13901: [SPARK-16199][SQL] Add a method to list the referenced c...

Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the issue:

    https://github.com/apache/spark/pull/13901
  
    @rxin I added tests to this pull request and submitted https://github.com/apache/spark/pull/14120


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #13901: [SPARK-16199][SQL] Add a method to list the refer...

Posted by rxin <gi...@git.apache.org>.
Github user rxin closed the pull request at:

    https://github.com/apache/spark/pull/13901


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #13901: [SPARK-16199][SQL] Add a method to list the referenced c...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/13901
  
    **[Test build #61209 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61209/consoleFull)** for PR 13901 at commit [`846c0e4`](https://github.com/apache/spark/commit/846c0e4ddec35352b07c9a4f72769bcceecfa25e).
     * This patch **fails MiMa tests**.
     * This patch merges cleanly.
     * This patch adds the following public classes _(experimental)_:
      * `abstract class Filter `
      * `case class EqualTo(attribute: String, value: Any) extends Filter `
      * `case class EqualNullSafe(attribute: String, value: Any) extends Filter `
      * `case class GreaterThan(attribute: String, value: Any) extends Filter `
      * `case class GreaterThanOrEqual(attribute: String, value: Any) extends Filter `
      * `case class LessThan(attribute: String, value: Any) extends Filter `
      * `case class LessThanOrEqual(attribute: String, value: Any) extends Filter `
      * `case class IsNull(attribute: String) extends Filter `
      * `case class IsNotNull(attribute: String) extends Filter `
      * `case class And(left: Filter, right: Filter) extends Filter `
      * `case class Or(left: Filter, right: Filter) extends Filter `
      * `case class Not(child: Filter) extends Filter `
      * `case class StringStartsWith(attribute: String, value: String) extends Filter `
      * `case class StringEndsWith(attribute: String, value: String) extends Filter `
      * `case class StringContains(attribute: String, value: String) extends Filter `


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #13901: [SPARK-16199][SQL] Add a method to list the referenced c...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/13901
  
    Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #13901: [SPARK-16199][SQL] Add a method to list the referenced c...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/13901
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61209/
    Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #13901: [SPARK-16199][SQL] Add a method to list the referenced c...

Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on the issue:

    https://github.com/apache/spark/pull/13901
  
    No tests?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org