You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/01/16 22:51:18 UTC

[GitHub] xtinec commented on a change in pull request #6667: [WIP] [SIP-6] Remove backend logic of tablevis.

xtinec commented on a change in pull request #6667: [WIP] [SIP-6] Remove backend logic of tablevis.
URL: https://github.com/apache/incubator-superset/pull/6667#discussion_r248481682
 
 

 ##########
 File path: superset/views/api.py
 ##########
 @@ -18,7 +18,7 @@ class Api(BaseSupersetView):
     @api
     @handle_api_exception
     @has_access_api
-    @expose('/v1/query', methods=['POST'])
+    @expose('/v1/query/', methods=['POST'])
 
 Review comment:
   hmm, I thought we decided to drop the `/` to avoid calling the endpoint with `/v1/query/?slice_id...`, no?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org