You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2017/11/02 06:10:37 UTC

[GitHub] yush1ga commented on a change in pull request #877: Namespace-isolation policy should consider secondary brokers

yush1ga commented on a change in pull request #877: Namespace-isolation policy should consider secondary brokers
URL: https://github.com/apache/incubator-pulsar/pull/877#discussion_r148449001
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/LoadManagerShared.java
 ##########
 @@ -52,7 +52,7 @@
     private static final Set<String> primariesCache = new HashSet<>();
 
     // Cache for shard brokers according to policies.
-    private static final Set<String> sharedCache = new HashSet<>();
+    private static final Set<String> secondary = new HashSet<>();
 
 Review comment:
   The name should be `secondariesCache` like `primariesCache` and the description should be changed, shouldn't it ?
   (at least, `shard` may be typo.)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services