You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2011/01/25 23:51:46 UTC
[jira] Created: (HADOOP-7118) NPE in Configuration.writeXml
NPE in Configuration.writeXml
-----------------------------
Key: HADOOP-7118
URL: https://issues.apache.org/jira/browse/HADOOP-7118
Project: Hadoop Common
Issue Type: Bug
Affects Versions: 0.22.0
Reporter: Todd Lipcon
Assignee: Todd Lipcon
Priority: Blocker
Fix For: 0.22.0
In HADOOP-7082 I stupidly introduced a regression whereby Configuration.writeXml will throw an NPE if it is called before any .get() call is made, since the properties member is not initialized. This is causing a failure in TestCapacitySchedulerWithJobTracker on my box, but doesn't appear to trigger any failures in the non-contrib tests since .get() is usually called first.
This JIRA is to fix the bug and add a unit test for writeXml in common (apparently it never had a unit test)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7118) NPE in Configuration.writeXml
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986747#action_12986747 ]
Hadoop QA commented on HADOOP-7118:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12469351/hadoop-7118.txt
against trunk revision 1063090.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/198//console
This message is automatically generated.
> NPE in Configuration.writeXml
> -----------------------------
>
> Key: HADOOP-7118
> URL: https://issues.apache.org/jira/browse/HADOOP-7118
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Blocker
> Fix For: 0.22.0
>
> Attachments: hadoop-7118.txt
>
>
> In HADOOP-7082 I stupidly introduced a regression whereby Configuration.writeXml will throw an NPE if it is called before any .get() call is made, since the properties member is not initialized. This is causing a failure in TestCapacitySchedulerWithJobTracker on my box, but doesn't appear to trigger any failures in the non-contrib tests since .get() is usually called first.
> This JIRA is to fix the bug and add a unit test for writeXml in common (apparently it never had a unit test)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7118) NPE in Configuration.writeXml
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989123#comment-12989123 ]
Hudson commented on HADOOP-7118:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #492 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/492/])
> NPE in Configuration.writeXml
> -----------------------------
>
> Key: HADOOP-7118
> URL: https://issues.apache.org/jira/browse/HADOOP-7118
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Blocker
> Fix For: 0.22.0
>
> Attachments: hadoop-7118.txt, hadoop-7118.txt
>
>
> In HADOOP-7082 I stupidly introduced a regression whereby Configuration.writeXml will throw an NPE if it is called before any .get() call is made, since the properties member is not initialized. This is causing a failure in TestCapacitySchedulerWithJobTracker on my box, but doesn't appear to trigger any failures in the non-contrib tests since .get() is usually called first.
> This JIRA is to fix the bug and add a unit test for writeXml in common (apparently it never had a unit test)
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HADOOP-7118) NPE in Configuration.writeXml
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-7118:
--------------------------------
Attachment: hadoop-7118.txt
Woops, patch was against yesterday's common tree, didn't apply. Take two.
> NPE in Configuration.writeXml
> -----------------------------
>
> Key: HADOOP-7118
> URL: https://issues.apache.org/jira/browse/HADOOP-7118
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Blocker
> Fix For: 0.22.0
>
> Attachments: hadoop-7118.txt, hadoop-7118.txt
>
>
> In HADOOP-7082 I stupidly introduced a regression whereby Configuration.writeXml will throw an NPE if it is called before any .get() call is made, since the properties member is not initialized. This is causing a failure in TestCapacitySchedulerWithJobTracker on my box, but doesn't appear to trigger any failures in the non-contrib tests since .get() is usually called first.
> This JIRA is to fix the bug and add a unit test for writeXml in common (apparently it never had a unit test)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-7118) NPE in Configuration.writeXml
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-7118:
--------------------------------
Status: Patch Available (was: Open)
> NPE in Configuration.writeXml
> -----------------------------
>
> Key: HADOOP-7118
> URL: https://issues.apache.org/jira/browse/HADOOP-7118
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Blocker
> Fix For: 0.22.0
>
> Attachments: hadoop-7118.txt
>
>
> In HADOOP-7082 I stupidly introduced a regression whereby Configuration.writeXml will throw an NPE if it is called before any .get() call is made, since the properties member is not initialized. This is causing a failure in TestCapacitySchedulerWithJobTracker on my box, but doesn't appear to trigger any failures in the non-contrib tests since .get() is usually called first.
> This JIRA is to fix the bug and add a unit test for writeXml in common (apparently it never had a unit test)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7118) NPE in Configuration.writeXml
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986944#action_12986944 ]
Hudson commented on HADOOP-7118:
--------------------------------
Integrated in Hadoop-Common-trunk #587 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/587/])
HADOOP-7118. Fix NPE in Configuration.writeXml. Contributed by Todd Lipcon
> NPE in Configuration.writeXml
> -----------------------------
>
> Key: HADOOP-7118
> URL: https://issues.apache.org/jira/browse/HADOOP-7118
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Blocker
> Fix For: 0.22.0
>
> Attachments: hadoop-7118.txt, hadoop-7118.txt
>
>
> In HADOOP-7082 I stupidly introduced a regression whereby Configuration.writeXml will throw an NPE if it is called before any .get() call is made, since the properties member is not initialized. This is causing a failure in TestCapacitySchedulerWithJobTracker on my box, but doesn't appear to trigger any failures in the non-contrib tests since .get() is usually called first.
> This JIRA is to fix the bug and add a unit test for writeXml in common (apparently it never had a unit test)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7118) NPE in Configuration.writeXml
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986768#action_12986768 ]
Hadoop QA commented on HADOOP-7118:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12469356/hadoop-7118.txt
against trunk revision 1063090.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/199//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/199//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/199//console
This message is automatically generated.
> NPE in Configuration.writeXml
> -----------------------------
>
> Key: HADOOP-7118
> URL: https://issues.apache.org/jira/browse/HADOOP-7118
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Blocker
> Fix For: 0.22.0
>
> Attachments: hadoop-7118.txt, hadoop-7118.txt
>
>
> In HADOOP-7082 I stupidly introduced a regression whereby Configuration.writeXml will throw an NPE if it is called before any .get() call is made, since the properties member is not initialized. This is causing a failure in TestCapacitySchedulerWithJobTracker on my box, but doesn't appear to trigger any failures in the non-contrib tests since .get() is usually called first.
> This JIRA is to fix the bug and add a unit test for writeXml in common (apparently it never had a unit test)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-7118) NPE in Configuration.writeXml
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-7118:
--------------------------------
Attachment: hadoop-7118.txt
> NPE in Configuration.writeXml
> -----------------------------
>
> Key: HADOOP-7118
> URL: https://issues.apache.org/jira/browse/HADOOP-7118
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Blocker
> Fix For: 0.22.0
>
> Attachments: hadoop-7118.txt
>
>
> In HADOOP-7082 I stupidly introduced a regression whereby Configuration.writeXml will throw an NPE if it is called before any .get() call is made, since the properties member is not initialized. This is causing a failure in TestCapacitySchedulerWithJobTracker on my box, but doesn't appear to trigger any failures in the non-contrib tests since .get() is usually called first.
> This JIRA is to fix the bug and add a unit test for writeXml in common (apparently it never had a unit test)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7118) NPE in Configuration.writeXml
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986771#action_12986771 ]
Konstantin Boudnik commented on HADOOP-7118:
--------------------------------------------
+1 LGTM. I would also convert the test to JUnitv4 but one can't have everything, I guess ;)
> NPE in Configuration.writeXml
> -----------------------------
>
> Key: HADOOP-7118
> URL: https://issues.apache.org/jira/browse/HADOOP-7118
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Blocker
> Fix For: 0.22.0
>
> Attachments: hadoop-7118.txt, hadoop-7118.txt
>
>
> In HADOOP-7082 I stupidly introduced a regression whereby Configuration.writeXml will throw an NPE if it is called before any .get() call is made, since the properties member is not initialized. This is causing a failure in TestCapacitySchedulerWithJobTracker on my box, but doesn't appear to trigger any failures in the non-contrib tests since .get() is usually called first.
> This JIRA is to fix the bug and add a unit test for writeXml in common (apparently it never had a unit test)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-7118) NPE in Configuration.writeXml
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-7118:
--------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed, thanks for review Cos.
> NPE in Configuration.writeXml
> -----------------------------
>
> Key: HADOOP-7118
> URL: https://issues.apache.org/jira/browse/HADOOP-7118
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Blocker
> Fix For: 0.22.0
>
> Attachments: hadoop-7118.txt, hadoop-7118.txt
>
>
> In HADOOP-7082 I stupidly introduced a regression whereby Configuration.writeXml will throw an NPE if it is called before any .get() call is made, since the properties member is not initialized. This is causing a failure in TestCapacitySchedulerWithJobTracker on my box, but doesn't appear to trigger any failures in the non-contrib tests since .get() is usually called first.
> This JIRA is to fix the bug and add a unit test for writeXml in common (apparently it never had a unit test)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7118) NPE in Configuration.writeXml
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986928#action_12986928 ]
Hudson commented on HADOOP-7118:
--------------------------------
Integrated in Hadoop-Common-22-branch #19 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-22-branch/19/])
HADOOP-7118. Fix NPE in Configuration.writeXml. Contributed by Todd Lipcon
> NPE in Configuration.writeXml
> -----------------------------
>
> Key: HADOOP-7118
> URL: https://issues.apache.org/jira/browse/HADOOP-7118
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Blocker
> Fix For: 0.22.0
>
> Attachments: hadoop-7118.txt, hadoop-7118.txt
>
>
> In HADOOP-7082 I stupidly introduced a regression whereby Configuration.writeXml will throw an NPE if it is called before any .get() call is made, since the properties member is not initialized. This is causing a failure in TestCapacitySchedulerWithJobTracker on my box, but doesn't appear to trigger any failures in the non-contrib tests since .get() is usually called first.
> This JIRA is to fix the bug and add a unit test for writeXml in common (apparently it never had a unit test)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.