[GitHub] [airflow] XD-DENG commented on a change in pull request #5127: [AIRFLOW-4343] Show warning in UI if scheduler is not running

[GitBox <gi...@apache.org>]

XD-DENG commented on a change in pull request #5127: [AIRFLOW-4343] Show warning in UI if scheduler is not running
URL: https://github.com/apache/airflow/pull/5127#discussion_r277744869
 
 

 ##########
 File path: airflow/config_templates/default_airflow.cfg
 ##########
 @@ -464,11 +464,6 @@ dag_dir_list_interval = 300
 # How often should stats be printed to the logs
 print_stats_interval = 30
 
-# If the last scheduler heartbeat happened more than scheduler_health_check_threshold ago (in seconds),
-# scheduler is considered unhealthy.
-# This is used by the health check in the "/health" endpoint
-scheduler_health_check_threshold = 30
 
 Review comment:
   @ashb , I would suggest to keep this setting and let SchedulerJob use it as a fixed heartbeat timeout. Number `2.1` here is just too confusing to me.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services