You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/07/09 16:29:48 UTC
[GitHub] [geode] nonbinaryprogrammer opened a new pull request #6685: GEODE-9340: move benchmark baseline
nonbinaryprogrammer opened a new pull request #6685:
URL: https://github.com/apache/geode/pull/6685
The new baseline is the commit that caused a slight performance
regression in our most sensitive tests. There is a negligible
performance difference between the previous baseline of 1.13.3 and the
commit before the commit that caused the regression (commit with SHA
217be41f087072026ea3b411b89107700edfb5f7). This means that moving the
baseline will not ignore a bunch of other performance changes.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] onichols-pivotal commented on pull request #6685: GEODE-9340: move benchmark baseline
Posted by GitBox <gi...@apache.org>.
onichols-pivotal commented on pull request #6685:
URL: https://github.com/apache/geode/pull/6685#issuecomment-877343652
> We just need the baseline to be something after the dependency version bumps
But 1.13.3 has the same jetty dependency bump...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] nonbinaryprogrammer commented on pull request #6685: GEODE-9340: move benchmark baseline
Posted by GitBox <gi...@apache.org>.
nonbinaryprogrammer commented on pull request #6685:
URL: https://github.com/apache/geode/pull/6685#issuecomment-877339807
> This will be overwritten by the next release (either 1.13.4 or 1.14.0), is that ok? Or does this need to be pinned in perpetuity?
Yes, that is fine. this is a temporary fix to move the baseline past that regression so that tests stop failing in CI. The next release will also be passed that regression, so it will also be ok. We just need the baseline to be something after the dependency version bumps
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] onichols-pivotal commented on pull request #6685: GEODE-9340: move benchmark baseline
Posted by GitBox <gi...@apache.org>.
onichols-pivotal commented on pull request #6685:
URL: https://github.com/apache/geode/pull/6685#issuecomment-877320826
This will be overwritten by the next release (either 1.13.4 or 1.14.0), is that ok? Or does this need to be pinned in perpetuity?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] nonbinaryprogrammer commented on pull request #6685: GEODE-9340: move benchmark baseline
Posted by GitBox <gi...@apache.org>.
nonbinaryprogrammer commented on pull request #6685:
URL: https://github.com/apache/geode/pull/6685#issuecomment-877349708
> > We just need the baseline to be something after the dependency version bumps
>
> But 1.13.3 has the same jetty dependency bump...
1.13.3 does not contain the dependency bump, which is a problem. if 1.13.4 does not contain the dependency bump and is the next released version, then we will need to keep the baseline as the above commit until a version that contains it. so definitely 1.14.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] nonbinaryprogrammer commented on pull request #6685: GEODE-9340: move benchmark baseline
Posted by GitBox <gi...@apache.org>.
nonbinaryprogrammer commented on pull request #6685:
URL: https://github.com/apache/geode/pull/6685#issuecomment-877380408
Closing as unnecessary and closing out the ticket.
When I left for vacation two weeks ago, the baseline was 1.13.2, which was causing the performance issue. During those two weeks, the baseline was moved to 1.13.3, which resolves the performance issue. So setting the baseline to this specific commit is no longer necessary. This change was made by the following commit: 5b5748300fb7b783e1a75c54f0dda750b89cc4f5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] nonbinaryprogrammer closed pull request #6685: GEODE-9340: move benchmark baseline
Posted by GitBox <gi...@apache.org>.
nonbinaryprogrammer closed pull request #6685:
URL: https://github.com/apache/geode/pull/6685
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org