[GitHub] [felix-dev] amitjoy commented on pull request #192: Updated to use HTTP optionally in HealthCheck

["amitjoy (via GitHub)" <gi...@apache.org>]

amitjoy commented on PR #192:
URL: https://github.com/apache/felix-dev/pull/192#issuecomment-1406520354

   I just added a new commit to update to HTTP whiteboard. There was no runtime issue to use the old pattern of using `HttpService` to register the servlets, but dependency to `HttpService` introduces a mandatory requirement to `osgi.service` namespace. 
   
   `osgi.service;filter:="(objectClass=org.osgi.service.http.HttpService)";effective:=active`
   
   This requirement doesn't play any role in the runtime but it plays a signifact role of composing systems. If we use bndtools and use this bundle as an initial requirement to resolve the dependencies, this will fail as the `requirement` needs to be satisfied first. We also use similar mechanism to compose systems using OSGi Resolver which would not work if the comprises such mandatory dependency to `HttpService`. That's why, a cleaner approach would be to go for OSGi HTTP Whiteboard where dependency to `HttpService` is not required at all, whereas, it now optionally requires HTTP whiteboard.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org