[GitHub] [airflow] potiuk opened a new pull request, #26150: Fail "early build cache" if breeze shell command is not quick

[GitBox <gi...@apache.org>]

potiuk opened a new pull request, #26150:
URL: https://github.com/apache/airflow/pull/26150

   This is a follow-up after #26148 where we found out that basic
   breeze command took far more time than it should when user
   answered "yes" to rebuild the image.
   
   This PR adds `--max-time` parameter to `breze shell` command which
   forces "exit" to be executed as command and fails if the command
   does not complete in time specified.
   
   This command is run in "early build cache" so failure there will
   not fail the whole build (the job has "continue on error" set),
   but we will see the "red" status of the `main` workflow in case
   the build takes longer than 120 seconds - indicating that the
   build takes too long.
   
   We only run it for `amd` images because if we have a problem
   there, we will have similar problem in arm images.
   
   We make sure to clear the docker cache before the command is run
   to make sure that it runs in "clean" state.
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #26150: Fail "early build cache" if breeze shell command is not quick

[GitBox <gi...@apache.org>]

potiuk merged PR #26150:
URL: https://github.com/apache/airflow/pull/26150


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org