You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by "MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1)" <ma...@hp.com> on 2003/03/26 19:16:28 UTC
[PATCH] mod_auth_ldap does not compile with WROWE_2_0_45_RC1
This is probably the cause.
[If strnicmp is available on a platform, but strncasecmp is not, then it's
#defined in apr_general.h]
--Madhu
Index: mod_auth_ldap.c
===================================================================
RCS file: /home/cvspublic/httpd-2.0/modules/experimental/mod_auth_ldap.c,v
retrieving revision 1.8.2.4
diff -r1.8.2.4 mod_auth_ldap.c
823c823
< if (strnicmp(url, "ldaps", 5) == 0)
---
> if (strncasecmp(url, "ldaps", 5) == 0)
Re: [PATCH] mod_auth_ldap does not compile with
WROWE_2_0_45_RC1
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
At 01:52 PM 3/26/2003, Jeff Trawick wrote:
>MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1) wrote:
>>This is probably the cause.
>>[If strnicmp is available on a platform, but strncasecmp is not, then it's
>>#defined in apr_general.h]
>>diff -r1.8.2.4 mod_auth_ldap.c
>>823c823
>>< if (strnicmp(url, "ldaps", 5) == 0)
>>---
>>
>>> if (strncasecmp(url, "ldaps", 5) == 0)
>
>so commit to HEAD ASAP and perhaps before long you'll have the last +1 for commiting to stable (right now you have yours and mine)
Make that three +1, mine... this was simply bogus code ;-)
Btw... -u diffs please :-)
Your point is taken, we should collect three, so perhaps my commit was
premature, so I apologize. Anyways, with these three +1's, this will make
it into the final .45 tag. Nice catch Madhu.
Bill
Re: [PATCH] mod_auth_ldap does not compile with WROWE_2_0_45_RC1
Posted by Jeff Trawick <tr...@attglobal.net>.
MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1) wrote:
> This is probably the cause.
>
> [If strnicmp is available on a platform, but strncasecmp is not, then it's
> #defined in apr_general.h]
>
> --Madhu
>
> Index: mod_auth_ldap.c
> ===================================================================
> RCS file: /home/cvspublic/httpd-2.0/modules/experimental/mod_auth_ldap.c,v
> retrieving revision 1.8.2.4
> diff -r1.8.2.4 mod_auth_ldap.c
> 823c823
> < if (strnicmp(url, "ldaps", 5) == 0)
> ---
>
>> if (strncasecmp(url, "ldaps", 5) == 0)
>
>
so commit to HEAD ASAP and perhaps before long you'll have the last +1
for commiting to stable (right now you have yours and mine)