You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/10/25 01:37:52 UTC
[GitHub] [hudi] Zhangshunyu opened a new pull request, #7053: [HUDI-5087]Fix incorrect maxValue getting from metatable
Zhangshunyu opened a new pull request, #7053:
URL: https://github.com/apache/hudi/pull/7053
[HUDI-5087]Fix incorrect maxValue getting from metatable
### Change Logs
_Describe context and summary for this change. Highlight if any code was copied._
### Impact
_Describe any public API or user-facing feature change or any performance impact._
### Risk level (write none, low medium or high below)
_If medium or high, explain what verification was done to mitigate the risks._
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a diff in pull request #7053: [HUDI-5087]Fix incorrect maxValue getting from metatable
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on code in PR #7053:
URL: https://github.com/apache/hudi/pull/7053#discussion_r1003973859
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataPayload.java:
##########
@@ -639,8 +639,8 @@ private static HoodieMetadataColumnStats mergeColumnStatsRecords(HoodieMetadataC
Comparable maxValue =
(Comparable) Stream.of(
- (Comparable) unwrapStatisticValueWrapper(prevColumnStats.getMinValue()),
- (Comparable) unwrapStatisticValueWrapper(newColumnStats.getMinValue()))
+ (Comparable) unwrapStatisticValueWrapper(prevColumnStats.getMaxValue()),
+ (Comparable) unwrapStatisticValueWrapper(newColumnStats.getMaxValue()))
Review Comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] alexeykudinkin merged pull request #7053: [HUDI-5087] Fix incorrect merging sequence for Column Stats Record in `HoodieMetadataPayload`
Posted by GitBox <gi...@apache.org>.
alexeykudinkin merged PR #7053:
URL: https://github.com/apache/hudi/pull/7053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7053: [HUDI-5087] Fix incorrect merging sequence for Column Stats Record in `HoodieMetadataPayload`
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7053:
URL: https://github.com/apache/hudi/pull/7053#issuecomment-1291197875
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7a6d2403895f9dda929d352d1abf808b357a8896",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12549",
"triggerID" : "7a6d2403895f9dda929d352d1abf808b357a8896",
"triggerType" : "PUSH"
}, {
"hash" : "6ce0ce024bbd5c90b3e0d9092d6123bae6916ab1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6ce0ce024bbd5c90b3e0d9092d6123bae6916ab1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7a6d2403895f9dda929d352d1abf808b357a8896 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12549)
* 6ce0ce024bbd5c90b3e0d9092d6123bae6916ab1 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #7053: [HUDI-5087] Fix incorrect merging sequence for Column Stats Record in `HoodieMetadataPayload`
Posted by GitBox <gi...@apache.org>.
alexeykudinkin commented on code in PR #7053:
URL: https://github.com/apache/hudi/pull/7053#discussion_r1005002407
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataPayload.java:
##########
@@ -639,8 +639,8 @@ private static HoodieMetadataColumnStats mergeColumnStatsRecords(HoodieMetadataC
Comparable maxValue =
(Comparable) Stream.of(
- (Comparable) unwrapStatisticValueWrapper(prevColumnStats.getMinValue()),
- (Comparable) unwrapStatisticValueWrapper(newColumnStats.getMinValue()))
+ (Comparable) unwrapStatisticValueWrapper(prevColumnStats.getMaxValue()),
+ (Comparable) unwrapStatisticValueWrapper(newColumnStats.getMaxValue()))
Review Comment:
Added the tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7053: [HUDI-5087] Fix incorrect merging sequence for Column Stats Record in `HoodieMetadataPayload`
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7053:
URL: https://github.com/apache/hudi/pull/7053#issuecomment-1291538041
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7a6d2403895f9dda929d352d1abf808b357a8896",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12549",
"triggerID" : "7a6d2403895f9dda929d352d1abf808b357a8896",
"triggerType" : "PUSH"
}, {
"hash" : "6ce0ce024bbd5c90b3e0d9092d6123bae6916ab1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12577",
"triggerID" : "6ce0ce024bbd5c90b3e0d9092d6123bae6916ab1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6ce0ce024bbd5c90b3e0d9092d6123bae6916ab1 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12577)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7053: [HUDI-5087]Fix incorrect maxValue getting from metatable
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7053:
URL: https://github.com/apache/hudi/pull/7053#issuecomment-1290331752
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7a6d2403895f9dda929d352d1abf808b357a8896",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12549",
"triggerID" : "7a6d2403895f9dda929d352d1abf808b357a8896",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7a6d2403895f9dda929d352d1abf808b357a8896 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12549)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] alexeykudinkin commented on pull request #7053: [HUDI-5087] Fix incorrect merging sequence for Column Stats Record in `HoodieMetadataPayload`
Posted by GitBox <gi...@apache.org>.
alexeykudinkin commented on PR #7053:
URL: https://github.com/apache/hudi/pull/7053#issuecomment-1292294623
CI is green:
<img width="1627" alt="Screen Shot 2022-10-26 at 9 20 33 AM" src="https://user-images.githubusercontent.com/428277/198080617-6a025660-4cb2-4076-a410-b266b7afd719.png">
https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=12577&view=results
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #7053: [HUDI-5087]Fix incorrect maxValue getting from metatable
Posted by GitBox <gi...@apache.org>.
danny0405 commented on code in PR #7053:
URL: https://github.com/apache/hudi/pull/7053#discussion_r1003920600
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataPayload.java:
##########
@@ -639,8 +639,8 @@ private static HoodieMetadataColumnStats mergeColumnStatsRecords(HoodieMetadataC
Comparable maxValue =
(Comparable) Stream.of(
- (Comparable) unwrapStatisticValueWrapper(prevColumnStats.getMinValue()),
- (Comparable) unwrapStatisticValueWrapper(newColumnStats.getMinValue()))
+ (Comparable) unwrapStatisticValueWrapper(prevColumnStats.getMaxValue()),
+ (Comparable) unwrapStatisticValueWrapper(newColumnStats.getMaxValue()))
Review Comment:
Nice catch, is there any possibility we write a unit test for this clazz ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] Zhangshunyu commented on pull request #7053: [HUDI-5087]Fix incorrect maxValue getting from metatable
Posted by GitBox <gi...@apache.org>.
Zhangshunyu commented on PR #7053:
URL: https://github.com/apache/hudi/pull/7053#issuecomment-1289867036
Hi @alexeykudinkin @nsivabalan, please help to check this PR , thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7053: [HUDI-5087]Fix incorrect maxValue getting from metatable
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7053:
URL: https://github.com/apache/hudi/pull/7053#issuecomment-1289902093
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7a6d2403895f9dda929d352d1abf808b357a8896",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12549",
"triggerID" : "7a6d2403895f9dda929d352d1abf808b357a8896",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7a6d2403895f9dda929d352d1abf808b357a8896 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12549)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7053: [HUDI-5087] Fix incorrect merging sequence for Column Stats Record in `HoodieMetadataPayload`
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7053:
URL: https://github.com/apache/hudi/pull/7053#issuecomment-1291201774
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7a6d2403895f9dda929d352d1abf808b357a8896",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12549",
"triggerID" : "7a6d2403895f9dda929d352d1abf808b357a8896",
"triggerType" : "PUSH"
}, {
"hash" : "6ce0ce024bbd5c90b3e0d9092d6123bae6916ab1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12577",
"triggerID" : "6ce0ce024bbd5c90b3e0d9092d6123bae6916ab1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7a6d2403895f9dda929d352d1abf808b357a8896 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12549)
* 6ce0ce024bbd5c90b3e0d9092d6123bae6916ab1 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12577)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7053: [HUDI-5087]Fix incorrect maxValue getting from metatable
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7053:
URL: https://github.com/apache/hudi/pull/7053#issuecomment-1289898186
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7a6d2403895f9dda929d352d1abf808b357a8896",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7a6d2403895f9dda929d352d1abf808b357a8896",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7a6d2403895f9dda929d352d1abf808b357a8896 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org