You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/09/08 02:28:37 UTC
[GitHub] [hudi] danny0405 commented on a change in pull request #3622: [HUDI-2402]Hive Sync supports Kerberos authentication
danny0405 commented on a change in pull request #3622:
URL: https://github.com/apache/hudi/pull/3622#discussion_r703976033
##########
File path: hudi-flink/src/main/java/org/apache/hudi/streamer/FlinkStreamerConfig.java
##########
@@ -369,6 +374,8 @@
conf.setBoolean(FlinkOptions.HIVE_SYNC_IGNORE_EXCEPTIONS, config.hiveSyncIgnoreExceptions);
conf.setBoolean(FlinkOptions.HIVE_SYNC_SKIP_RO_SUFFIX, config.hiveSyncSkipRoSuffix);
conf.setBoolean(FlinkOptions.HIVE_SYNC_SUPPORT_TIMESTAMP, config.hiveSyncSupportTimestamp);
+ conf.setBoolean(FlinkOptions.HIVE_SYNC_USE_KERBEROS, config.useKerberos);
+ conf.setString(FlinkOptions.HIVE_SYNC_KERBEROS_PRINCIPAL, config.kerberosPrincipal);
return conf;
Review comment:
Should decide if `config.kerberosPrincipal` is null first.
##########
File path: hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala
##########
@@ -191,6 +191,16 @@ object DataSourceWriteOptions {
.withAlternatives("hoodie.datasource.write.storage.type")
.withDocumentation("The table type for the underlying data, for this write. This can’t change between writes.")
+ val HIVE_SYNC_USE_KERBEROS: ConfigProperty[Boolean] = ConfigProperty
+ .key("hoodie.datasource.hive_sync.use_kerberos")
+ .defaultValue(false)
+ .withDocumentation("Whether to use Kerberos authentication.")
+
+ val HIVE_SYNC_KERBEROS_PRINCIPAL: ConfigProperty[String] = ConfigProperty
+ .key("hive_sync.kerberos_principal")
+ .noDefaultValue()
Review comment:
hoodie.datasource.hive_sync.kerberos_principal ? And move this option together with the other hive sync options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org