You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/08/20 06:29:59 UTC

[GitHub] [arrow] kou commented on a change in pull request #8002: ARROW-9532: [Python][Doc] Use Python3_EXECUTABLE instead of PYTHON_EXECUTABLE for finding Python executable

kou commented on a change in pull request #8002:
URL: https://github.com/apache/arrow/pull/8002#discussion_r473645378



##########
File path: python/setup.py
##########
@@ -224,7 +224,7 @@ def _run_cmake(self):
             static_lib_option = ''
 
             cmake_options = [
-                '-DPYTHON_EXECUTABLE=%s' % sys.executable,

Review comment:
       Ah, could you keep this?
   If we can both `PYTHON_EXECUTABLE` and `Python3_EXECUTABLE`, it works on newer and older CMake.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org