You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/01/30 03:00:30 UTC

[GitHub] [shardingsphere] shankeerthan-kasilingam opened a new pull request #15203: Dev 14246

shankeerthan-kasilingam opened a new pull request #15203:
URL: https://github.com/apache/shardingsphere/pull/15203


   Fixes #14246.
   
   **Fixed** : 
   shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-dialect/shardingsphere-data-pipeline-mysql/src/test/java/org/apache/shardingsphere/data/pipeline/mysql/prepare/datasource/MySQLDataSourcePreparerTest.java
   
   **Added  internal dependencies to the subproject:**
   
   shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-dialect/shardingsphere-data-pipeline-mysql/pom.xml
   
   
   **Updated Mockito version to 3.4.2 :**
   
   shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-dialect/shardingsphere-data-pipeline-mysql/pom.xml
   
   For the above test cases, we have to mock **PipelineDataSourceConfigurationFactory**. Since **PipelineDataSourceConfigurationFactory**’s method is static, we have to use mockStatic. In Mockito 3.4.0, the same test cases will throw NotAMockException. It seems like a bug in Mockito 3.4.0 and they were fixed in 3.4.2.
   
   In local testing, any tests didn’t fail after changing the Mockito version from 3.4.0 to 3.4.2 
   
   [1]: https://github.com/mockito/mockito/pull/1968
   [2]: https://github.com/mockito/mockito/issues/1967
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu commented on pull request #15203: Fixes MySQLDataSourcePreparerTest

Posted by GitBox <gi...@apache.org>.
terrymanu commented on pull request #15203:
URL: https://github.com/apache/shardingsphere/pull/15203#issuecomment-1025065036


   Great Job


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu merged pull request #15203: Fixes MySQLDataSourcePreparerTest

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #15203:
URL: https://github.com/apache/shardingsphere/pull/15203


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org