You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2018/03/02 19:07:50 UTC
Review Request 65887: Avoided orphan subprocess in the Docker library.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65887/
-----------------------------------------------------------
Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.
Bugs: MESOS-8576
https://issues.apache.org/jira/browse/MESOS-8576
Repository: mesos
Description
-------
This patch ensures that `Docker::inspect` will not leave orphan
subprocesses behind.
Diffs
-----
src/docker/docker.cpp 9dd4ceb9928cce880a79f29cac00d799ecba5909
Diff: https://reviews.apache.org/r/65887/diff/1/
Testing
-------
sudo bin/mesos-tests.sh --gtest_filter="*DOCKER*"
Thanks,
Greg Mann
Re: Review Request 65887: Avoided orphan subprocess in the Docker
library.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65887/#review198570
-----------------------------------------------------------
Patch looks great!
Reviews applied: [65887]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 2, 2018, 7:07 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65887/
> -----------------------------------------------------------
>
> (Updated March 2, 2018, 7:07 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.
>
>
> Bugs: MESOS-8576
> https://issues.apache.org/jira/browse/MESOS-8576
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch ensures that `Docker::inspect` will not leave orphan
> subprocesses behind.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp 9dd4ceb9928cce880a79f29cac00d799ecba5909
>
>
> Diff: https://reviews.apache.org/r/65887/diff/1/
>
>
> Testing
> -------
>
> sudo bin/mesos-tests.sh --gtest_filter="*DOCKER*"
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 65887: Avoided orphan subprocess in the Docker
library.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65887/#review198561
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On March 2, 2018, 11:07 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65887/
> -----------------------------------------------------------
>
> (Updated March 2, 2018, 11:07 a.m.)
>
>
> Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.
>
>
> Bugs: MESOS-8576
> https://issues.apache.org/jira/browse/MESOS-8576
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch ensures that `Docker::inspect` will not leave orphan
> subprocesses behind.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp 9dd4ceb9928cce880a79f29cac00d799ecba5909
>
>
> Diff: https://reviews.apache.org/r/65887/diff/1/
>
>
> Testing
> -------
>
> sudo bin/mesos-tests.sh --gtest_filter="*DOCKER*"
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 65887: Avoided orphan subprocess in the Docker
library.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65887/#review198549
-----------------------------------------------------------
PASS: Mesos patch 65887 was successfully built and tested.
Reviews applied: `['65887']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65887
- Mesos Reviewbot Windows
On March 2, 2018, 7:07 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65887/
> -----------------------------------------------------------
>
> (Updated March 2, 2018, 7:07 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.
>
>
> Bugs: MESOS-8576
> https://issues.apache.org/jira/browse/MESOS-8576
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch ensures that `Docker::inspect` will not leave orphan
> subprocesses behind.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp 9dd4ceb9928cce880a79f29cac00d799ecba5909
>
>
> Diff: https://reviews.apache.org/r/65887/diff/1/
>
>
> Testing
> -------
>
> sudo bin/mesos-tests.sh --gtest_filter="*DOCKER*"
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 65887: Avoided orphan subprocess in the Docker
library.
Posted by Andrei Budnik <ab...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65887/#review198562
-----------------------------------------------------------
Ship it!
Ship It!
- Andrei Budnik
On March 2, 2018, 7:07 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65887/
> -----------------------------------------------------------
>
> (Updated March 2, 2018, 7:07 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.
>
>
> Bugs: MESOS-8576
> https://issues.apache.org/jira/browse/MESOS-8576
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch ensures that `Docker::inspect` will not leave orphan
> subprocesses behind.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp 9dd4ceb9928cce880a79f29cac00d799ecba5909
>
>
> Diff: https://reviews.apache.org/r/65887/diff/1/
>
>
> Testing
> -------
>
> sudo bin/mesos-tests.sh --gtest_filter="*DOCKER*"
>
>
> Thanks,
>
> Greg Mann
>
>