You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Hitesh Khamesra <hk...@pivotal.io> on 2017/04/12 17:34:04 UTC

Review Request 58391: GEODE-2193 Now we don't send view if shutdown process is started.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58391/
-----------------------------------------------------------

Review request for geode and Bruce Schuchardt.


Repository: geode


Description
-------

Earlier we were checking flag, which was set after sending the shutdown
    message. Now we check flag, which was set before sending the shutdown
    message.


Diffs
-----

  geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionManager.java 3efbafc 
  geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/interfaces/Manager.java 3fe8cc1 
  geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java e4066ef 
  geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/mgr/GMSMembershipManager.java 0180ddb 


Diff: https://reviews.apache.org/r/58391/diff/1/


Testing
-------


Thanks,

Hitesh Khamesra


Re: Review Request 58391: GEODE-2193 Now we don't send view if shutdown process is started.

Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58391/#review171758
-----------------------------------------------------------


Ship it!




Ship It!

- Bruce Schuchardt


On April 12, 2017, 5:34 p.m., Hitesh Khamesra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58391/
> -----------------------------------------------------------
> 
> (Updated April 12, 2017, 5:34 p.m.)
> 
> 
> Review request for geode and Bruce Schuchardt.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Earlier we were checking flag, which was set after sending the shutdown
>     message. Now we check flag, which was set before sending the shutdown
>     message.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionManager.java 3efbafc 
>   geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/interfaces/Manager.java 3fe8cc1 
>   geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java e4066ef 
>   geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/mgr/GMSMembershipManager.java 0180ddb 
> 
> 
> Diff: https://reviews.apache.org/r/58391/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hitesh Khamesra
> 
>