You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Brian Topping (JIRA)" <ji...@codehaus.org> on 2006/02/20 14:12:28 UTC
[jira] Commented: (MWAR-12) Add resource filtering to war plugin
[ http://jira.codehaus.org/browse/MWAR-12?page=comments#action_59006 ]
Brian Topping commented on MWAR-12:
-----------------------------------
I started working on a solution to this, not realizing that it was already in JIRA.
When I tried this a few weeks ago, my assumption was that I would add a <resources> block to the project POM. Since it already specified <packaging>war</packaging>, I just assumed that the same configuration would work here, but it doesn't.
Having gone through quite a bit of the code for both plugins by now, I can attest to the complexity of the resource filtering and how it would be good to avoid duplicating that into the war plugin. So I'm +1 for linking having these work together. It seems like a lot of the code in AbstractWarMojo.java could be removed if that were the case, and it looks like the class has had a lot of authors, so it would be worth doing.
> Add resource filtering to war plugin
> ------------------------------------
>
> Key: MWAR-12
> URL: http://jira.codehaus.org/browse/MWAR-12
> Project: Maven 2.x War Plugin
> Type: Improvement
> Reporter: Mark Hobson
> Assignee: Brett Porter
> Attachments: test.zip
>
> Original Estimate: 15 minutes
> Remaining: 15 minutes
>
> I'd like to patch the war plugin to perform resource filtering as per the resources plugin. This is a trivial patch but would duplicate the following code from the resources plugin:
> PropertyUtils
> ReflectionProperties
> ResourcesMojo.copyFile(File, File)
> These look like handy util methods that could be incorporated into plexus-utils - what do the developers think?
> Also not sure how resource filtering will be affected by MNG-788.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org