You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by lei-xia <gi...@git.apache.org> on 2014/10/20 23:30:16 UTC
[GitHub] helix pull request: [HELIX-525] Add integration tests to verify th...
GitHub user lei-xia opened a pull request:
https://github.com/apache/helix/pull/7
[HELIX-525] Add integration tests to verify that dropping a partition from resource ...
Add integration tests to verify that dropping a partition from resource ideal-state should bring partition to initial state and then DROPPED state (for AUTO, SEMI_AUTO, and CUSTOM modes).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lei-xia/helix master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/helix/pull/7.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #7
----
commit 51b757b71693ec2f774035eac441dd51956e5862
Author: Lei Xia <lx...@linkedin.com>
Date: 2014-10-20T21:09:16Z
Add integration tests to verify that dropping a partition from resource ideal-state should bring partition to initial state and then DROPPED state (for AUTO, SEMI_AUTO, and CUSTOM modes).
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] helix pull request: [HELIX-525] Add integration tests to verify th...
Posted by kanakb <gi...@git.apache.org>.
Github user kanakb commented on the pull request:
https://github.com/apache/helix/pull/7#issuecomment-60031395
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] helix pull request: [HELIX-525] Add integration tests to verify th...
Posted by lei-xia <gi...@git.apache.org>.
Github user lei-xia commented on the pull request:
https://github.com/apache/helix/pull/7#issuecomment-60014784
It is actually not necessary, thanks for pointing out. I updated it, also use TestNG dataprovider to supply RebalanceMode to avoid write one test method for each mode. I will apply the same strategy to many of our existing tests to testing code redundancy in following checkins if you guys are happy with it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] helix pull request: [HELIX-525] Add integration tests to verify th...
Posted by kanakb <gi...@git.apache.org>.
Github user kanakb commented on a diff in the pull request:
https://github.com/apache/helix/pull/7#discussion_r19130517
--- Diff: helix-core/src/test/java/org/apache/helix/integration/TestDrop.java ---
@@ -481,11 +507,27 @@ public void testDropSinglePartitionSemiAuto() throws Exception {
4, // partitions per resource
n, // number of nodes
2, // replicas
- "MasterSlave", true); // do rebalance
+ "MasterSlave", mode, (IdealState.RebalanceMode.FULL_AUTO.equals(mode) || IdealState.RebalanceMode.SEMI_AUTO
+ .equals(mode))); // do rebalance only when it is in AUTO or SEMI-AUTO mode
--- End diff --
Why is the default rebalance behavior insufficient for CUSTOMIZED mode?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] helix pull request: [HELIX-525] Add integration tests to verify th...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/helix/pull/7
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---