You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "polandll (via GitHub)" <gi...@apache.org> on 2023/06/27 17:52:56 UTC
[GitHub] [cassandra] polandll opened a new pull request, #2452: Cass 18606
polandll opened a new pull request, #2452:
URL: https://github.com/apache/cassandra/pull/2452
Thanks for sending a pull request! Here are some tips if you're new here:
* Ensure you have added or run the [appropriate tests](https://cassandra.apache.org/_/development/testing.html) for your PR.
* Be sure to keep the PR description updated to reflect all changes.
* Write your PR title to summarize what this PR proposes.
* If possible, provide a concise example to reproduce the issue for a faster review.
* Read our [contributor guidelines](https://cassandra.apache.org/_/development/index.html)
* If you're making a documentation change, see our [guide to documentation contribution](https://cassandra.apache.org/_/development/documentation.html)
Commit messages should follow the following format:
```
<One sentence description, usually Jira title or CHANGES.txt summary>
<Optional lengthier description (context on patch)>
patch by <Authors>; reviewed by <Reviewers> for CASSANDRA-#####
Co-authored-by: Name1 <email1>
Co-authored-by: Name2 <email2>
```
The [Cassandra Jira](https://issues.apache.org/jira/projects/CASSANDRA/issues/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] polandll commented on pull request #2452: CASSANDRA-18606 Fix leftnav cross-references
Posted by "polandll (via GitHub)" <gi...@apache.org>.
polandll commented on PR #2452:
URL: https://github.com/apache/cassandra/pull/2452#issuecomment-1663075139
@michaelsembwever Unbeknownst to me, someone else wrote cassandra-website/content/doc/trunk/cassandra/managing/virtualtables.adoc back into the repo. I'm not quite sure how to get rid of it, because, of course, it doesn't exist in my branch, so I can't "delete" it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] polandll closed pull request #2452: CASSANDRA-18606 Fix leftnav cross-references
Posted by "polandll (via GitHub)" <gi...@apache.org>.
polandll closed pull request #2452: CASSANDRA-18606 Fix leftnav cross-references
URL: https://github.com/apache/cassandra/pull/2452
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] polandll commented on pull request #2452: CASSANDRA-18606 Fix leftnav cross-references
Posted by "polandll (via GitHub)" <gi...@apache.org>.
polandll commented on PR #2452:
URL: https://github.com/apache/cassandra/pull/2452#issuecomment-1670192409
Closing and reopening due to merge conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] michaelsembwever commented on pull request #2452: CASSANDRA-18606 Fix leftnav cross-references
Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on PR #2452:
URL: https://github.com/apache/cassandra/pull/2452#issuecomment-1612796909
to test i run
```
./run.sh website container -a BUILD_USER_ARG:$(whoami) -a UID_ARG:$(id -u) -a GID_ARG:$(id -g)
./run.sh website build -g -b cassandra:CASS-18606 -u cassandra:https://github.com/polandll/cassandra
```
(on macos i needed some small fixes, pushed [here](https://github.com/apache/cassandra-website/commit/466d6ffe4624b4a4a09b9946472045a7d48097ea))
Via the navigation i can now reach the new pages.
An example of a new page: `cassandra-website/content/doc/trunk/cassandra/managing/virtualtables.html`
and an example of the old page: `cassandra-website/content/doc/trunk/cassandra/managing/operating/virtualtables.html`
Side question, for this page why do both still exist ?
Another side question, the navigation does not visually structure as the IA (and underlying files) do. Is that intentional?
Screenshot of the nav bar
<img width="388" alt="Screenshot 2023-06-29 at 11 47 35" src="https://github.com/apache/cassandra/assets/559444/423a857a-b752-4a93-8ff6-41292fb07066">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org