You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/05/31 22:34:20 UTC
[GitHub] michellethomas commented on a change in pull request #5118: Adding
the MetricsControl to the timeseries_limit_metric field
michellethomas commented on a change in pull request #5118: Adding the MetricsControl to the timeseries_limit_metric field
URL: https://github.com/apache/incubator-superset/pull/5118#discussion_r192256580
##########
File path: superset/connectors/druid/models.py
##########
@@ -1148,6 +1148,11 @@ def run_query( # noqa / druid
metric['column']['type'].upper() == 'FLOAT'
):
metric['column']['type'] = 'DOUBLE'
+ if (
+ utils.is_adhoc_metric(timeseries_limit_metric) and
+ timeseries_limit_metric['column']['type'].upper() == 'FLOAT'
Review comment:
The version check is happening a few lines above. https://github.com/apache/incubator-superset/pull/5118/files#diff-a8dd5ec8d8decda2e3c5571d1ec0cdb6R1141
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org