You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/06/24 09:06:48 UTC
[GitHub] [incubator-tvm] lixiaoquan opened a new pull request #5912: Fix serialization of inf float value
lixiaoquan opened a new pull request #5912:
URL: https://github.com/apache/incubator-tvm/pull/5912
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen merged pull request #5912: Fix serialization of inf float value
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #5912:
URL: https://github.com/apache/incubator-tvm/pull/5912
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] junrushao1994 commented on pull request #5912: Fix serialization of inf float value
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #5912:
URL: https://github.com/apache/incubator-tvm/pull/5912#issuecomment-648946404
Good catch! Do we also want to support NaN as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] lixiaoquan commented on pull request #5912: Fix serialization of inf float value
Posted by GitBox <gi...@apache.org>.
lixiaoquan commented on pull request #5912:
URL: https://github.com/apache/incubator-tvm/pull/5912#issuecomment-649143385
> Good catch! Do we also want to support NaN as well?
Thanks for mentioning that, I'll send another PR for that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] lixiaoquan commented on pull request #5912: Fix serialization of inf float value
Posted by GitBox <gi...@apache.org>.
lixiaoquan commented on pull request #5912:
URL: https://github.com/apache/incubator-tvm/pull/5912#issuecomment-649142890
> Thanks @lixiaoquan ! it appears that I merged pre-maturely, can you followup with a testcase that covers the fix? Thank you
This PR includes a test called test_infinity_value().
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on pull request #5912: Fix serialization of inf float value
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #5912:
URL: https://github.com/apache/incubator-tvm/pull/5912#issuecomment-648904452
Thanks @lixiaoquan ! it appears that I merged pre-maturely, can you followup with a testcase that covers the fix? Thank you
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org