You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "zeroshade (via GitHub)" <gi...@apache.org> on 2023/07/17 19:59:30 UTC
[GitHub] [arrow-adbc] zeroshade opened a new pull request, #909: fix(go/adbc/driver/snowflake): handle non-arrow result sets
zeroshade opened a new pull request, #909:
URL: https://github.com/apache/arrow-adbc/pull/909
Closes #863
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on a diff in pull request #909: fix(go/adbc/driver/snowflake): handle non-arrow result sets
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #909:
URL: https://github.com/apache/arrow-adbc/pull/909#discussion_r1265872010
##########
go/adbc/driver/snowflake/driver_test.go:
##########
@@ -358,10 +358,15 @@ func (suite *SnowflakeTests) TestStatementEmptyResultSet() {
// XXX: there IS data in this result set, but Snowflake doesn't
// appear to support getting the results as Arrow
Review Comment:
Outdated comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] zeroshade merged pull request #909: fix(go/adbc/driver/snowflake): handle non-arrow result sets
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #909:
URL: https://github.com/apache/arrow-adbc/pull/909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] zeroshade commented on pull request #909: fix(go/adbc/driver/snowflake): handle non-arrow result sets
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #909:
URL: https://github.com/apache/arrow-adbc/pull/909#issuecomment-1638878426
@lidavidm Hm. In theory we probably could upstream more of this than I did. Right now the only thing I upstreamed was making the `[][]*string` accessible in the loader, the `extractTimestamp` function is mostly pulled from snowflake's library directly. Right now the upstream snowflake library has many things for converting *from* Arrow to other types, but doesn't convert *to* arrow.
The only drawback to pushing this upstream is that it puts us back into the situation where we run into problems between the Arrow major version in snowflake vs the Arrow major version in ADBC. Right now we get to avoid that issue by having the conversion here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on pull request #909: fix(go/adbc/driver/snowflake): handle non-arrow result sets
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #909:
URL: https://github.com/apache/arrow-adbc/pull/909#issuecomment-1638882370
Ok, sounds good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org