You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@uima.apache.org by "Adam Lally (JIRA)" <ui...@incubator.apache.org> on 2006/11/17 17:51:37 UTC

[jira] Created: (UIMA-46) Duplicate feature name on supertype and subtype does not work if subtype definition comes first in descriptor

Duplicate feature name on supertype and subtype does not work if subtype definition comes first in descriptor
-------------------------------------------------------------------------------------------------------------

                 Key: UIMA-46
                 URL: http://issues.apache.org/jira/browse/UIMA-46
             Project: UIMA
          Issue Type: Bug
            Reporter: Adam Lally
         Assigned To: Adam Lally


If a user's type system declares an identical named feature on a supertype and one of its subtypes, it works as long as the supertype definition comes first in the XML type system descriptor.  (The subtype definition is ignored.)  But if the subtype definition comes first, then the feature is only created on the subtype, NOT the supertype.  We should make this consistent, so that the feature is always created on the supertype.  



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Re: [jira] Created: (UIMA-46) Duplicate feature name on supertype and subtype does not work if subtype definition comes first in descriptor

Posted by Adam Lally <al...@alum.rpi.edu>.
On 11/17/06, Thilo Goetz <tw...@gmx.de> wrote:
> Is this something you would like to see fixed in the TypeSystemMgr, or
> in the code that calls the TypeSystemMgr?  I believe I can probably fix
> it in the TypeSystemMgr without too much work.
>

I already committed the fix for it in the code that calls
TypeSystemMgr (CasCreationUtils).  I already have to create the
supertype before I can create the subtype, so it was easy for me to
also add the features to the supertype befor adding them to the
subtype.

However, I think a further question is: should we produce a warning if
the user has declared a duplicate feature name on a supertype and one
of its subtypes?  If we think that makes sense we can open a JIRA nit
to record this.

-Adam

Re: [jira] Created: (UIMA-46) Duplicate feature name on supertype and subtype does not work if subtype definition comes first in descriptor

Posted by Thilo Goetz <tw...@gmx.de>.
Is this something you would like to see fixed in the TypeSystemMgr, or 
in the code that calls the TypeSystemMgr?  I believe I can probably fix 
it in the TypeSystemMgr without too much work.

--Thilo

Adam Lally (JIRA) wrote:
> Duplicate feature name on supertype and subtype does not work if subtype definition comes first in descriptor
> -------------------------------------------------------------------------------------------------------------
> 
>                  Key: UIMA-46
>                  URL: http://issues.apache.org/jira/browse/UIMA-46
>              Project: UIMA
>           Issue Type: Bug
>             Reporter: Adam Lally
>          Assigned To: Adam Lally
> 
> 
> If a user's type system declares an identical named feature on a supertype and one of its subtypes, it works as long as the supertype definition comes first in the XML type system descriptor.  (The subtype definition is ignored.)  But if the subtype definition comes first, then the feature is only created on the subtype, NOT the supertype.  We should make this consistent, so that the feature is always created on the supertype.  
> 
> 
> 

[jira] Closed: (UIMA-46) Duplicate feature name on supertype and subtype does not work if subtype definition comes first in descriptor

Posted by "Adam Lally (JIRA)" <ui...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/UIMA-46?page=all ]

Adam Lally closed UIMA-46.
--------------------------

    Resolution: Fixed

Fixed by changing CasCreationUtils to always add features to supertypes before adding features to subtypes.

> Duplicate feature name on supertype and subtype does not work if subtype definition comes first in descriptor
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: UIMA-46
>                 URL: http://issues.apache.org/jira/browse/UIMA-46
>             Project: UIMA
>          Issue Type: Bug
>            Reporter: Adam Lally
>         Assigned To: Adam Lally
>
> If a user's type system declares an identical named feature on a supertype and one of its subtypes, it works as long as the supertype definition comes first in the XML type system descriptor.  (The subtype definition is ignored.)  But if the subtype definition comes first, then the feature is only created on the subtype, NOT the supertype.  We should make this consistent, so that the feature is always created on the supertype.  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira