You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/07/05 16:43:33 UTC
[GitHub] [incubator-tvm] jwfromm opened a new pull request #5995: [Relay][Frontend][Onnx] Small bug fix for Conv1D imports.
jwfromm opened a new pull request #5995:
URL: https://github.com/apache/incubator-tvm/pull/5995
When importing a Conv1D operation with VALID padding, a Relay error would be produced due to the onnx frontend producing a tuple with only one element instead of two as expected. Adding `get_pad_tuple1d` to the `make_conv1d` call covers this and is more robust than the previous approach.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] masahi commented on pull request #5995: [Relay][Frontend][Onnx] Small bug fix for Conv1D imports.
Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #5995:
URL: https://github.com/apache/incubator-tvm/pull/5995#issuecomment-653984938
Thanks @jwfromm @tmoreau89 @junrushao1994
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] masahi merged pull request #5995: [Relay][Frontend][Onnx] Small bug fix for Conv1D imports.
Posted by GitBox <gi...@apache.org>.
masahi merged pull request #5995:
URL: https://github.com/apache/incubator-tvm/pull/5995
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] jwfromm commented on pull request #5995: [Relay][Frontend][Onnx] Small bug fix for Conv1D imports.
Posted by GitBox <gi...@apache.org>.
jwfromm commented on pull request #5995:
URL: https://github.com/apache/incubator-tvm/pull/5995#issuecomment-653910795
@masahi, @areusch, @tmoreau89 can one of you guys take a look at this quick PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org