You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/02/07 17:32:31 UTC

[GitHub] [superset] aliamzhang edited a comment on pull request #18594: fix: sqllab schema select error msg

aliamzhang edited a comment on pull request #18594:
URL: https://github.com/apache/superset/pull/18594#issuecomment-1031730332


   > I noticed that the fix does not change the tests, and evidently such a situation should be detected by automatic tests. Do you have any idea how to develop the current tests so that such systems are detected automatically?
   > 
   > The 404 response from the Superset server indicates that something went very wrong and I wonder if we should not catch it in some general way in automatic tests.
   
   submit automated tests in this pr or open a new pr?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org