[GitHub] [lucene] Yuti-G commented on pull request #915: LUCENE-10585: Scrub copy/paste code in the facets module and attempt to simplify a bit

[GitBox <gi...@apache.org>]

Yuti-G commented on PR #915:
URL: https://github.com/apache/lucene/pull/915#issuecomment-1135050190

   Hi @gsmiller, thanks for making a lot of improvements to the code, and it looks great to me! I also ran the benchmarks for facet and do not observe much difference from the main branch. I added getTopDims to benchmarks but the PR hasn't merged yet, so the attached results are from my local. Thanks!
   
   Main:
   <img width="810" alt="Screen Shot 2022-05-23 at 11 12 26 AM" src="https://user-images.githubusercontent.com/44444710/169889777-cf059966-a38d-49b8-8699-e8ff5172967c.png">
   
   pr/915:
   <img width="830" alt="Screen Shot 2022-05-23 at 12 17 42 PM" src="https://user-images.githubusercontent.com/44444710/169890719-ec235cb4-4f49-47f9-9ca0-a1f822073bf5.png">
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org