You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2021/09/04 16:25:27 UTC
[GitHub] [openwhisk-deploy-kube] pankaj-dahiya opened a new issue #701: Unable to pull pre-warm images from private docker registry
pankaj-dahiya opened a new issue #701:
URL: https://github.com/apache/openwhisk-deploy-kube/issues/701
I am unable to pull pre-warm image - "myregistry/action-nodejs-v10" from my private gitlab registry.
Steps to replicate:
Pre-requisite - A private docker registry and a Kubernetes secret pre-built to pull images.
1. Pull open whisk helm chart.
2. Edit _helpers.tpl file as below:
{{/* ImagePullSecrets in pods and job*/}}
{{- define "openwhisk.docker.imagePullSecrets" -}}
imagePullSecrets:
- name: myRegistrySecret
{{- end -}}
3. edit openwhisk image name as per private docker registry (myregistry/openwhiskImageName).
4. Helm install
---------------------------------------------------------------------------
All images will be pulled successfully and all the pods will get into a running state. But Pre-warm pods will give an error as "ErrImagePull".
----------------------------------------------------------------------------
There are no documents supporting how can we define a imagePullSecrets for pre-warm pods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-deploy-kube] pankaj-dahiya edited a comment on issue #701: Unable to pull pre-warm images from private docker registry
Posted by GitBox <gi...@apache.org>.
pankaj-dahiya edited a comment on issue #701:
URL: https://github.com/apache/openwhisk-deploy-kube/issues/701#issuecomment-913300199
Hi, @dgrove-oss I deploying open whisk via helm carts, In helm charts, there is an option in values.yaml which asks us to private docker registry and its credentials which are further passed to templates/_invoker-helpers.tpl.
So, as per me, providing registry credentials in values.yaml must be enough!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-deploy-kube] dgrove-oss edited a comment on issue #701: Unable to pull pre-warm images from private docker registry
Posted by GitBox <gi...@apache.org>.
dgrove-oss edited a comment on issue #701:
URL: https://github.com/apache/openwhisk-deploy-kube/issues/701#issuecomment-913223975
Is it only the preWarm pods that are having trouble pulling the image, or is it a problem for any pod being created by an invoker using this image to run user actions?
I'd speculate you are probably seeing the later, which means the `imagePullSecret` needs to be propagated into the pod template the invoker uses to create user action pods. There is poorly documented support for doing this by injecting a value into the invoker's configuration value: `whisk.kubernetes.podTemplate` https://github.com/apache/openwhisk/blob/master/core/invoker/src/main/resources/application.conf#L87-#L91.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-deploy-kube] pankaj-dahiya edited a comment on issue #701: Unable to pull pre-warm images from private docker registry
Posted by GitBox <gi...@apache.org>.
pankaj-dahiya edited a comment on issue #701:
URL: https://github.com/apache/openwhisk-deploy-kube/issues/701#issuecomment-913300199
Hi, @dgrove-oss I deploying Openwhisk via helm carts, In helm charts, there is an option in values.yaml which asks us to private docker registry and its credentials which are further passed to templates/_invoker-helpers.tpl.
So, as per me, providing registry credentials in values.yaml must be enough!
One more thing, as per industry standards, the User should provide a .Values.imagePullSecretsin values.yaml and that should be propagated to everywhere else but in Openwhisk this is completely useless as this .Values.imagePullSecrets is not passed anywhere to any pods of Openwhisk and we must provide our registry credentials to Openwhisk that too in plain text format!.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-deploy-kube] pankaj-dahiya closed issue #701: Unable to pull pre-warm images from private docker registry
Posted by GitBox <gi...@apache.org>.
pankaj-dahiya closed issue #701:
URL: https://github.com/apache/openwhisk-deploy-kube/issues/701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-deploy-kube] dgrove-oss commented on issue #701: Unable to pull pre-warm images from private docker registry
Posted by GitBox <gi...@apache.org>.
dgrove-oss commented on issue #701:
URL: https://github.com/apache/openwhisk-deploy-kube/issues/701#issuecomment-914328497
The helm chart supports using a private registry with the DockerContainerFactory. It is missing support for using the KubernetesContainerFactory with a private registry. Contributions would be welcome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-deploy-kube] pankaj-dahiya commented on issue #701: Unable to pull pre-warm images from private docker registry
Posted by GitBox <gi...@apache.org>.
pankaj-dahiya commented on issue #701:
URL: https://github.com/apache/openwhisk-deploy-kube/issues/701#issuecomment-913300199
Hi, @dgrove-oss I deploying open whisk via helm carts, In helm charts, there is an option in values.yaml whisk asks us to private docker registry and its credentials which are further passed to templates/_invoker-helpers.tpl.
So, as per me, providing registry credentials in values.yaml must be enough!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-deploy-kube] pankaj-dahiya edited a comment on issue #701: Unable to pull pre-warm images from private docker registry
Posted by GitBox <gi...@apache.org>.
pankaj-dahiya edited a comment on issue #701:
URL: https://github.com/apache/openwhisk-deploy-kube/issues/701#issuecomment-913300199
Hi, @dgrove-oss I am deploying Openwhisk via helm carts, In helm charts, there is an option in values.yaml which asks us to private docker registry and its credentials which are further passed to templates/_invoker-helpers.tpl.
So, as per me, providing registry credentials in values.yaml must be enough!
One more thing, as per industry standards, the User should provide a .Values.imagePullSecretsin values.yaml and that should be propagated to everywhere else but in Openwhisk this is completely useless as this .Values.imagePullSecrets is not passed anywhere to any pods of Openwhisk and we must provide our registry credentials to Openwhisk that too in plain text format!.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-deploy-kube] dgrove-oss commented on issue #701: Unable to pull pre-warm images from private docker registry
Posted by GitBox <gi...@apache.org>.
dgrove-oss commented on issue #701:
URL: https://github.com/apache/openwhisk-deploy-kube/issues/701#issuecomment-913223975
Is it only the preWarm pods that are having trouble pulling the image, or is it a problem for any pod being created by an invoker using this image to run user actions? I'd speculate you are probably seeing the later, which means the `imagePullSecret` needs to be propagated into the pod template the invoker uses to create user action pods. There is poorly documented support for doing this by injecting a value into the invoker's configuration value: `whisk.kubernetes.podTemplate` https://github.com/apache/openwhisk/blob/master/core/invoker/src/main/resources/application.conf#L87-#L91.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-deploy-kube] pankaj-dahiya edited a comment on issue #701: Unable to pull pre-warm images from private docker registry
Posted by GitBox <gi...@apache.org>.
pankaj-dahiya edited a comment on issue #701:
URL: https://github.com/apache/openwhisk-deploy-kube/issues/701#issuecomment-913300199
Hi, @dgrove-oss I am deploying Openwhisk via helm carts, In helm charts, there is an option in values.yaml which asks us to private docker registry and its credentials which are further passed to templates/_invoker-helpers.tpl where we define "openwhisk.docker_pull_runtimes" which includes these credentials.
So, as per me, providing registry credentials in values.yaml must be enough!
One more thing, as per industry standards, the User should provide a .Values.imagePullSecretsin values.yaml and that should be propagated to everywhere else but in Openwhisk this is completely useless as this .Values.imagePullSecrets is not passed anywhere to any pods of Openwhisk and we must provide our registry credentials to Openwhisk that too in plain text format!.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-deploy-kube] pankaj-dahiya commented on issue #701: Unable to pull pre-warm images from private docker registry
Posted by GitBox <gi...@apache.org>.
pankaj-dahiya commented on issue #701:
URL: https://github.com/apache/openwhisk-deploy-kube/issues/701#issuecomment-915789773
Hi ... this thing should also be supported in KubernatesContainerFactory. Will raise a PR by next month for this. (Bit busy now). So closing the issue as of now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org