You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/01/06 11:18:39 UTC
[GitHub] [skywalking] mestarshine opened a new pull request #4185: update
agent.config
mestarshine opened a new pull request #4185: update agent.config
URL: https://github.com/apache/skywalking/pull/4185
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [ ] New feature provided
- [ ] Improve performance
- Related issues
___
### Bug fix
- Bug description.
apm-sniffer/config/agent.config
Negative number means sample traces as many as possible, most likely 100%，
This note is inaccurate
- How to fix?
Negative or zero means off, by default
___
### New feature or improvement
- Describe the details and related test reports.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng merged pull request #4185: update agent.config
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #4185: update agent.config
URL: https://github.com/apache/skywalking/pull/4185
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4185: update
agent.config
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4185: update agent.config
URL: https://github.com/apache/skywalking/pull/4185#issuecomment-571113433
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4185?src=pr&el=h1) Report
> Merging [#4185](https://codecov.io/gh/apache/skywalking/pull/4185?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/f181f7b4830b05c6812878ccd4b23633163ea39a?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4185?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4185 +/- ##
==========================================
- Coverage 26.84% 26.81% -0.03%
==========================================
Files 1163 1163
Lines 25426 25426
Branches 3691 3691
==========================================
- Hits 6826 6819 -7
- Misses 17991 17998 +7
Partials 609 609
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4185?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...apm/agent/core/remote/GRPCStreamServiceStatus.java](https://codecov.io/gh/apache/skywalking/pull/4185/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENTdHJlYW1TZXJ2aWNlU3RhdHVzLmphdmE=) | `29.16% <0%> (-25.01%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/4185/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `60.36% <0%> (-0.91%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4185?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4185?src=pr&el=footer). Last update [f181f7b...bcfa1ed](https://codecov.io/gh/apache/skywalking/pull/4185?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services