[GitHub] [streampipes] bossenti commented on a diff in pull request #1037: [#877] Apply UI linting to configuration module

[GitBox <gi...@apache.org>]

bossenti commented on code in PR #1037:
URL: https://github.com/apache/streampipes/pull/1037#discussion_r1062406517


##########
ui/src/app/configuration/consul-configs-boolean/consul-configs-boolean.component.ts:
##########
@@ -21,14 +21,12 @@ import { StreampipesPeContainerConifgs } from '../shared/streampipes-pe-containe
 import { ConfigurationService } from '../shared/configuration.service';
 
 @Component({
-    selector: 'consul-configs-boolean',
+    selector: 'sp-consul-configs-boolean',

Review Comment:
   Shouldn't this also be reflected in the file name? 🤔 
   Also we should probably double-check if all references are updated



##########
ui/src/app/configuration/consul-configs-number/consul-configs-number.component.ts:
##########
@@ -21,13 +21,11 @@ import { StreampipesPeContainerConifgs } from '../shared/streampipes-pe-containe
 import { ConfigurationService } from '../shared/configuration.service';
 
 @Component({
-    selector: 'consul-configs-number',
+    selector: 'sp-consul-configs-number',

Review Comment:
   same as `consul-configs-boolean`



##########
ui/src/app/configuration/messaging-configuration/messaging-configuration.component.ts:
##########
@@ -25,24 +25,26 @@ import { SpBreadcrumbService } from '@streampipes/shared-ui';
 import { SpConfigurationRoutes } from '../configuration.routes';
 
 @Component({
-    selector: 'messaging-configuration',
+    selector: 'sp-messaging-configuration',

Review Comment:
   same as above



##########
ui/src/app/configuration/consul-service/consul-service.component.ts:
##########
@@ -20,27 +20,23 @@ import { Component, EventEmitter, Input, Output } from '@angular/core';
 import { StreampipesPeContainer } from '../shared/streampipes-pe-container.model';
 
 @Component({
-    selector: 'consul-service',
+    selector: 'sp-consul-service',

Review Comment:
   same as `consul-configs-boolean`



##########
ui/src/app/configuration/consul-configs-password/consul-configs-password.component.ts:
##########
@@ -23,13 +23,12 @@ import { ConfigurationService } from '../shared/configuration.service';
 const hiddenPasswordString = '*****';
 
 @Component({
-    selector: 'consul-configs-password',
+    selector: 'sp-consul-configs-password',

Review Comment:
   same as `consul-configs-boolean`



##########
ui/src/app/configuration/consul-configs-text/consul-configs-text.component.ts:
##########
@@ -21,14 +21,12 @@ import { StreampipesPeContainerConifgs } from '../shared/streampipes-pe-containe
 import { ConfigurationService } from '../shared/configuration.service';
 
 @Component({
-    selector: 'consul-configs-text',
+    selector: 'sp-consul-configs-text',

Review Comment:
   same as `consul-configs-boolean`



##########
ui/src/app/configuration/consul-configs/consul-configs.component.ts:
##########
@@ -21,20 +21,19 @@ import { StreampipesPeContainer } from '../shared/streampipes-pe-container.model
 import { XsService } from '../../NS/xs.service';
 
 @Component({
-  selector: 'consul-configs',
-  templateUrl: './consul-configs.component.html',
-  styleUrls: ['./consul-configs.component.css'],
-  providers: [XsService]
+    selector: 'sp-consul-configs',

Review Comment:
   same as `consul-configs-boolean`



##########
ui/src/app/configuration/pipeline-element-configuration/pipeline-element-configuration.component.ts:
##########
@@ -28,92 +34,113 @@ import { SpBreadcrumbService } from '@streampipes/shared-ui';
 import { SpConfigurationRoutes } from '../configuration.routes';
 
 @Component({
-  selector: 'pipeline-element-configuration',
-  templateUrl: './pipeline-element-configuration.component.html',
-  styleUrls: ['./pipeline-element-configuration.component.css'],
-  animations: [
-    trigger('detailExpand', [
-      state('collapsed', style({height: '0px', minHeight: '0', display: 'none'})),
-      state('expanded', style({height: '*'})),
-      transition('expanded <=> collapsed', animate('225ms cubic-bezier(0.4, 0.0, 0.2, 1)')),
-    ]),
-  ]
+    selector: 'sp-pipeline-element-configuration',

Review Comment:
   same as above



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org