[jira] Updated: (HADOOP-6346) Add support for specifying unpack pattern regex to RunJar.unJar

["Todd Lipcon (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HADOOP-6346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HADOOP-6346:
--------------------------------

    Attachment: hadoop-6346.txt

bq. hm.. I see the problem. But It's odd that we may not unjar "classes" directory depending on the pattern but still put it on the classpath. May be we should only put the workDir and the direct contents of it on the classpath? Thoughts? Any other ideas? Or leave the classpath alone?

I think we should leave the classpath alone. As this patch stands, it's not a breaking change, but getting rid of classes/ from the classpath would be. It's already also being put on the classpath even in the case when it doesn't exist, which doesn't cause any problems.

bq. Either you can add dummy directories/files under src/test/mapred/testjar/ and build the jar(search for testjar in build.xml).

This only exists in the mapreduce build, not in common. This patch is now in common, so no such luck.

bq. build a jar yourselves using JarOutputStream inside the test itself

Done. New patch attached that includes this unit test.

> Add support for specifying unpack pattern regex to RunJar.unJar
> ---------------------------------------------------------------
>
>                 Key: HADOOP-6346
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6346
>             Project: Hadoop Common
>          Issue Type: Task
>          Components: conf, util
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.22.0
>
>         Attachments: hadoop-6346.txt, hadoop-6346.txt, hadoop-6346.txt
>
>
> The changes in Common necessary for MAPREDUCE-967:
> - Adds support for Pattern types to Configuration (plus unit test)
> - Adds support to specify a Pattern to RunJar.unJar to decide which files get unpacked

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.