[GitHub] [guacamole-server] mike-jumper commented on a change in pull request #365: GUACAMOLE-1503: Japanese Character input cannot be switched By full-width half-width key.

[GitBox <gi...@apache.org>]

mike-jumper commented on a change in pull request #365:
URL: https://github.com/apache/guacamole-server/pull/365#discussion_r786324787



##########
File path: src/protocols/rdp/settings.c
##########
@@ -1393,6 +1393,11 @@ void guac_rdp_push_settings(guac_client* client,
     rdp_settings->AlternateShell = guac_strdup(guac_settings->initial_program);
     rdp_settings->KeyboardLayout = guac_settings->server_layout->freerdp_keyboard_layout;
 
+    /* Add GUACAMOLE-1503: Fixed so that full-width and half-width keys work correctly and Japanese input switching works. */
+    rdp_settings->KeyboardType = 7;
+    rdp_settings->KeyboardSubType = 2;
+    rdp_settings->KeyboardFunctionKey = 12;

Review comment:
       Fixed ... how? What is the reasoning behind this change, and what are these values? Are these values correct for all keyboards?

##########
File path: src/protocols/rdp/keymaps/ja_jp_qwerty.keymap
##########
@@ -32,5 +32,4 @@ map +shift      0x1E..0x28 0x2B ~ "ASDFGHJKL+*}"
 map +shift      0x2C..0x35 0x73 ~ "ZXCVBNM<>?_"
 
 map -shift      0x29            ~ 0xFF28
-map -shift      0x29            ~ 0xFF2A
-map +shift      0x29            ~ 0xFF29
+map -shift      0x29            ~ 0xFF29

Review comment:
       Can you clarify why this change is correct vs. the previous values?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org