You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Harish Butani <rh...@gmail.com> on 2014/02/20 00:24:32 UTC
Review Request 18293: HIVE-6393: Support unqualified column references in
Joining conditions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18293/
-----------------------------------------------------------
Review request for hive.
Repository: hive-git
Description
-------
Support queries of the form:
create table r1(a int);
create table r2(b);
select a, b
from r1 join r2 on a = b
This becomes more useful in old style syntax:
select a, b
from r1, r2
where a = b
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 77388dd
ql/src/test/org/apache/hadoop/hive/ql/parse/TestQBJoinTreeApplyPredicate.java 9e77949
ql/src/test/queries/clientpositive/join_cond_pushdown_unqual1.q PRE-CREATION
ql/src/test/queries/clientpositive/join_cond_pushdown_unqual2.q PRE-CREATION
ql/src/test/queries/clientpositive/join_cond_pushdown_unqual3.q PRE-CREATION
ql/src/test/queries/clientpositive/join_cond_pushdown_unqual4.q PRE-CREATION
ql/src/test/queries/clientpositive/subquery_unqualcolumnrefs.q PRE-CREATION
ql/src/test/results/clientpositive/join_cond_pushdown_unqual1.q.out PRE-CREATION
ql/src/test/results/clientpositive/join_cond_pushdown_unqual2.q.out PRE-CREATION
ql/src/test/results/clientpositive/join_cond_pushdown_unqual3.q.out PRE-CREATION
ql/src/test/results/clientpositive/join_cond_pushdown_unqual4.q.out PRE-CREATION
ql/src/test/results/clientpositive/subquery_unqualcolumnrefs.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/18293/diff/
Testing
-------
added new tests
ran all existing join tests
Thanks,
Harish Butani
Re: Review Request 18293: HIVE-6393: Support unqualified column references
in Joining conditions
Posted by Harish Butani <rh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18293/
-----------------------------------------------------------
(Updated Feb. 27, 2014, 6:56 p.m.)
Review request for hive, Ashutosh Chauhan and Gunther Hagleitner.
Changes
-------
updated.
Gunther thanks for your feedback.
Bugs: HIVE-6393
https://issues.apache.org/jira/browse/HIVE-6393
Repository: hive-git
Description
-------
Support queries of the form:
create table r1(a int);
create table r2(b);
select a, b
from r1 join r2 on a = b
This becomes more useful in old style syntax:
select a, b
from r1, r2
where a = b
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java a01aa0e
ql/src/test/org/apache/hadoop/hive/ql/parse/TestQBJoinTreeApplyPredicate.java 9e77949
ql/src/test/queries/clientnegative/join_cond_unqual_ambiguous.q PRE-CREATION
ql/src/test/queries/clientnegative/join_cond_unqual_ambiguous_vc.q PRE-CREATION
ql/src/test/queries/clientpositive/join_cond_pushdown_unqual1.q PRE-CREATION
ql/src/test/queries/clientpositive/join_cond_pushdown_unqual2.q PRE-CREATION
ql/src/test/queries/clientpositive/join_cond_pushdown_unqual3.q PRE-CREATION
ql/src/test/queries/clientpositive/join_cond_pushdown_unqual4.q PRE-CREATION
ql/src/test/queries/clientpositive/subquery_unqualcolumnrefs.q PRE-CREATION
ql/src/test/results/clientnegative/join_cond_unqual_ambiguous.q.out PRE-CREATION
ql/src/test/results/clientnegative/join_cond_unqual_ambiguous_vc.q.out PRE-CREATION
ql/src/test/results/clientpositive/join_cond_pushdown_unqual1.q.out PRE-CREATION
ql/src/test/results/clientpositive/join_cond_pushdown_unqual2.q.out PRE-CREATION
ql/src/test/results/clientpositive/join_cond_pushdown_unqual3.q.out PRE-CREATION
ql/src/test/results/clientpositive/join_cond_pushdown_unqual4.q.out PRE-CREATION
ql/src/test/results/clientpositive/subquery_unqualcolumnrefs.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/18293/diff/
Testing
-------
added new tests
ran all existing join tests
Thanks,
Harish Butani
Re: Review Request 18293: HIVE-6393: Support unqualified column references
in Joining conditions
Posted by Gunther Hagleitner <gh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18293/#review35511
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
<https://reviews.apache.org/r/18293/#comment66092>
Commenting on how you're finding the alias for the uninitiated might be a bonus too.
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
<https://reviews.apache.org/r/18293/#comment66093>
don't you have to check for isPresent on the right side too?
ql/src/test/queries/clientpositive/join_cond_pushdown_unqual1.q
<https://reviews.apache.org/r/18293/#comment66094>
not sure it matters but are virtual columns also resolved (they are in all tables so you kinda have to qualify anyways).
- Gunther Hagleitner
On Feb. 23, 2014, 3:28 a.m., Harish Butani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18293/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2014, 3:28 a.m.)
>
>
> Review request for hive, Ashutosh Chauhan and Gunther Hagleitner.
>
>
> Bugs: HIVE-6393
> https://issues.apache.org/jira/browse/HIVE-6393
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Support queries of the form:
>
> create table r1(a int);
> create table r2(b);
> select a, b
> from r1 join r2 on a = b
>
> This becomes more useful in old style syntax:
>
> select a, b
> from r1, r2
> where a = b
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java a01aa0e
> ql/src/test/org/apache/hadoop/hive/ql/parse/TestQBJoinTreeApplyPredicate.java 9e77949
> ql/src/test/queries/clientpositive/join_cond_pushdown_unqual1.q PRE-CREATION
> ql/src/test/queries/clientpositive/join_cond_pushdown_unqual2.q PRE-CREATION
> ql/src/test/queries/clientpositive/join_cond_pushdown_unqual3.q PRE-CREATION
> ql/src/test/queries/clientpositive/join_cond_pushdown_unqual4.q PRE-CREATION
> ql/src/test/queries/clientpositive/subquery_unqualcolumnrefs.q PRE-CREATION
> ql/src/test/results/clientpositive/join_cond_pushdown_unqual1.q.out PRE-CREATION
> ql/src/test/results/clientpositive/join_cond_pushdown_unqual2.q.out PRE-CREATION
> ql/src/test/results/clientpositive/join_cond_pushdown_unqual3.q.out PRE-CREATION
> ql/src/test/results/clientpositive/join_cond_pushdown_unqual4.q.out PRE-CREATION
> ql/src/test/results/clientpositive/subquery_unqualcolumnrefs.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18293/diff/
>
>
> Testing
> -------
>
> added new tests
> ran all existing join tests
>
>
> Thanks,
>
> Harish Butani
>
>
Re: Review Request 18293: HIVE-6393: Support unqualified column references
in Joining conditions
Posted by Gunther Hagleitner <gh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18293/#review35501
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
<https://reviews.apache.org/r/18293/#comment66054>
rawtypes because of Operator? Can't you use Operator<?> or Operator<? extends OperatorDesc>?
ql/src/test/queries/clientpositive/join_cond_pushdown_unqual1.q
<https://reviews.apache.org/r/18293/#comment66091>
I'm not sure that's covered elsewhere, but does it make sense to add some negative tests? (i.e.: doesn't exist, ambiguous etc)
- Gunther Hagleitner
On Feb. 23, 2014, 3:28 a.m., Harish Butani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18293/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2014, 3:28 a.m.)
>
>
> Review request for hive, Ashutosh Chauhan and Gunther Hagleitner.
>
>
> Bugs: HIVE-6393
> https://issues.apache.org/jira/browse/HIVE-6393
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Support queries of the form:
>
> create table r1(a int);
> create table r2(b);
> select a, b
> from r1 join r2 on a = b
>
> This becomes more useful in old style syntax:
>
> select a, b
> from r1, r2
> where a = b
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java a01aa0e
> ql/src/test/org/apache/hadoop/hive/ql/parse/TestQBJoinTreeApplyPredicate.java 9e77949
> ql/src/test/queries/clientpositive/join_cond_pushdown_unqual1.q PRE-CREATION
> ql/src/test/queries/clientpositive/join_cond_pushdown_unqual2.q PRE-CREATION
> ql/src/test/queries/clientpositive/join_cond_pushdown_unqual3.q PRE-CREATION
> ql/src/test/queries/clientpositive/join_cond_pushdown_unqual4.q PRE-CREATION
> ql/src/test/queries/clientpositive/subquery_unqualcolumnrefs.q PRE-CREATION
> ql/src/test/results/clientpositive/join_cond_pushdown_unqual1.q.out PRE-CREATION
> ql/src/test/results/clientpositive/join_cond_pushdown_unqual2.q.out PRE-CREATION
> ql/src/test/results/clientpositive/join_cond_pushdown_unqual3.q.out PRE-CREATION
> ql/src/test/results/clientpositive/join_cond_pushdown_unqual4.q.out PRE-CREATION
> ql/src/test/results/clientpositive/subquery_unqualcolumnrefs.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18293/diff/
>
>
> Testing
> -------
>
> added new tests
> ran all existing join tests
>
>
> Thanks,
>
> Harish Butani
>
>
Re: Review Request 18293: HIVE-6393: Support unqualified column references
in Joining conditions
Posted by Harish Butani <rh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18293/
-----------------------------------------------------------
(Updated Feb. 23, 2014, 3:28 a.m.)
Review request for hive, Ashutosh Chauhan and Gunther Hagleitner.
Changes
-------
fix .out files
Bugs: HIVE-6393
https://issues.apache.org/jira/browse/HIVE-6393
Repository: hive-git
Description
-------
Support queries of the form:
create table r1(a int);
create table r2(b);
select a, b
from r1 join r2 on a = b
This becomes more useful in old style syntax:
select a, b
from r1, r2
where a = b
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java a01aa0e
ql/src/test/org/apache/hadoop/hive/ql/parse/TestQBJoinTreeApplyPredicate.java 9e77949
ql/src/test/queries/clientpositive/join_cond_pushdown_unqual1.q PRE-CREATION
ql/src/test/queries/clientpositive/join_cond_pushdown_unqual2.q PRE-CREATION
ql/src/test/queries/clientpositive/join_cond_pushdown_unqual3.q PRE-CREATION
ql/src/test/queries/clientpositive/join_cond_pushdown_unqual4.q PRE-CREATION
ql/src/test/queries/clientpositive/subquery_unqualcolumnrefs.q PRE-CREATION
ql/src/test/results/clientpositive/join_cond_pushdown_unqual1.q.out PRE-CREATION
ql/src/test/results/clientpositive/join_cond_pushdown_unqual2.q.out PRE-CREATION
ql/src/test/results/clientpositive/join_cond_pushdown_unqual3.q.out PRE-CREATION
ql/src/test/results/clientpositive/join_cond_pushdown_unqual4.q.out PRE-CREATION
ql/src/test/results/clientpositive/subquery_unqualcolumnrefs.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/18293/diff/
Testing
-------
added new tests
ran all existing join tests
Thanks,
Harish Butani
Re: Review Request 18293: HIVE-6393: Support unqualified column references
in Joining conditions
Posted by Harish Butani <rh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18293/
-----------------------------------------------------------
(Updated Feb. 20, 2014, 1:54 a.m.)
Review request for hive, Ashutosh Chauhan and Gunther Hagleitner.
Changes
-------
fix lint issues
Bugs: HIVE-6393
https://issues.apache.org/jira/browse/HIVE-6393
Repository: hive-git
Description
-------
Support queries of the form:
create table r1(a int);
create table r2(b);
select a, b
from r1 join r2 on a = b
This becomes more useful in old style syntax:
select a, b
from r1, r2
where a = b
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 77388dd
ql/src/test/org/apache/hadoop/hive/ql/parse/TestQBJoinTreeApplyPredicate.java 9e77949
ql/src/test/queries/clientpositive/join_cond_pushdown_unqual1.q PRE-CREATION
ql/src/test/queries/clientpositive/join_cond_pushdown_unqual2.q PRE-CREATION
ql/src/test/queries/clientpositive/join_cond_pushdown_unqual3.q PRE-CREATION
ql/src/test/queries/clientpositive/join_cond_pushdown_unqual4.q PRE-CREATION
ql/src/test/queries/clientpositive/subquery_unqualcolumnrefs.q PRE-CREATION
ql/src/test/results/clientpositive/join_cond_pushdown_unqual1.q.out PRE-CREATION
ql/src/test/results/clientpositive/join_cond_pushdown_unqual2.q.out PRE-CREATION
ql/src/test/results/clientpositive/join_cond_pushdown_unqual3.q.out PRE-CREATION
ql/src/test/results/clientpositive/join_cond_pushdown_unqual4.q.out PRE-CREATION
ql/src/test/results/clientpositive/subquery_unqualcolumnrefs.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/18293/diff/
Testing
-------
added new tests
ran all existing join tests
Thanks,
Harish Butani