You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/10/05 00:18:09 UTC

[GitHub] [hudi] vinothchandar commented on a change in pull request #2115: [MINOR] Mark started and shutdownRequested with volatile.

vinothchandar commented on a change in pull request #2115:
URL: https://github.com/apache/hudi/pull/2115#discussion_r499304240



##########
File path: hudi-client/src/main/java/org/apache/hudi/async/AbstractAsyncService.java
##########
@@ -39,9 +39,9 @@
   private static final Logger LOG = LogManager.getLogger(AbstractAsyncService.class);
 
   // Flag to track if the service is started.
-  private boolean started;
+  private volatile boolean started;

Review comment:
       I think it makes sense to do this. `volatile` will ensure the other thread sees the update right away 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org