You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/09/10 08:53:36 UTC
[GitHub] [cloudstack] ravening opened a new pull request #4317: Display acl name in listNetworks response
ravening opened a new pull request #4317:
URL: https://github.com/apache/cloudstack/pull/4317
## Description
<!--- Describe your changes in detail -->
Display network acl name along with its id so that we
dont need to make extra api call `listNetworksAcllist`
to get acl name
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [X] Enhancement (improves an existing feature and functionality)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
Through cloudmonkey api
```
(local) mgt01 > list networks id=81f5-5f17-488a-be61-7d6ad99 filter=aclname
{
"count": 1,
"network": [
{
"aclname": "default_allow"
}
]
}
```
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on a change in pull request #4317: Display acl name in listNetworks response
Posted by GitBox <gi...@apache.org>.
ravening commented on a change in pull request #4317:
URL: https://github.com/apache/cloudstack/pull/4317#discussion_r487008659
##########
File path: api/src/main/java/org/apache/cloudstack/api/response/NetworkResponse.java
##########
@@ -238,6 +238,10 @@
@Param(description = "If the network has redundant routers enabled", since = "4.11.1")
private Boolean redundantRouter;
+ @SerializedName(ApiConstants.ACL_NAME)
+ @Param(description = "ACL name associated with the VPC network")
Review comment:
@shwstppr made the change
##########
File path: api/src/main/java/org/apache/cloudstack/api/response/NetworkResponse.java
##########
@@ -238,6 +238,10 @@
@Param(description = "If the network has redundant routers enabled", since = "4.11.1")
private Boolean redundantRouter;
+ @SerializedName(ApiConstants.ACL_NAME)
+ @Param(description = "ACL name associated with the VPC network")
Review comment:
@shwstppr made the change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb merged pull request #4317: Display acl name in listNetworks response
Posted by GitBox <gi...@apache.org>.
andrijapanicsb merged pull request #4317:
URL: https://github.com/apache/cloudstack/pull/4317
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb merged pull request #4317: Display acl name in listNetworks response
Posted by GitBox <gi...@apache.org>.
andrijapanicsb merged pull request #4317:
URL: https://github.com/apache/cloudstack/pull/4317
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #4317: Display acl name in listNetworks response
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #4317:
URL: https://github.com/apache/cloudstack/pull/4317#discussion_r486875250
##########
File path: api/src/main/java/org/apache/cloudstack/api/response/NetworkResponse.java
##########
@@ -238,6 +238,10 @@
@Param(description = "If the network has redundant routers enabled", since = "4.11.1")
private Boolean redundantRouter;
+ @SerializedName(ApiConstants.ACL_NAME)
+ @Param(description = "ACL name associated with the VPC network")
Review comment:
@ravening will it be better to add a since tag here?
##########
File path: api/src/main/java/org/apache/cloudstack/api/response/NetworkResponse.java
##########
@@ -238,6 +238,10 @@
@Param(description = "If the network has redundant routers enabled", since = "4.11.1")
private Boolean redundantRouter;
+ @SerializedName(ApiConstants.ACL_NAME)
+ @Param(description = "ACL name associated with the VPC network")
Review comment:
@ravening will it be better to add a since tag here?
##########
File path: api/src/main/java/org/apache/cloudstack/api/response/NetworkResponse.java
##########
@@ -238,6 +238,10 @@
@Param(description = "If the network has redundant routers enabled", since = "4.11.1")
private Boolean redundantRouter;
+ @SerializedName(ApiConstants.ACL_NAME)
+ @Param(description = "ACL name associated with the VPC network")
Review comment:
@ravening will it be better to add a since tag here?
##########
File path: api/src/main/java/org/apache/cloudstack/api/response/NetworkResponse.java
##########
@@ -238,6 +238,10 @@
@Param(description = "If the network has redundant routers enabled", since = "4.11.1")
private Boolean redundantRouter;
+ @SerializedName(ApiConstants.ACL_NAME)
+ @Param(description = "ACL name associated with the VPC network")
Review comment:
@ravening will it be better to add a since tag here?
##########
File path: api/src/main/java/org/apache/cloudstack/api/response/NetworkResponse.java
##########
@@ -238,6 +238,10 @@
@Param(description = "If the network has redundant routers enabled", since = "4.11.1")
private Boolean redundantRouter;
+ @SerializedName(ApiConstants.ACL_NAME)
+ @Param(description = "ACL name associated with the VPC network")
Review comment:
@ravening will it be better to add a since tag here?
##########
File path: api/src/main/java/org/apache/cloudstack/api/response/NetworkResponse.java
##########
@@ -238,6 +238,10 @@
@Param(description = "If the network has redundant routers enabled", since = "4.11.1")
private Boolean redundantRouter;
+ @SerializedName(ApiConstants.ACL_NAME)
+ @Param(description = "ACL name associated with the VPC network")
Review comment:
@ravening will it be better to add a since tag here?
##########
File path: api/src/main/java/org/apache/cloudstack/api/response/NetworkResponse.java
##########
@@ -238,6 +238,10 @@
@Param(description = "If the network has redundant routers enabled", since = "4.11.1")
private Boolean redundantRouter;
+ @SerializedName(ApiConstants.ACL_NAME)
+ @Param(description = "ACL name associated with the VPC network")
Review comment:
@ravening will it be better to add a since tag here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #4317: Display acl name in listNetworks response
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #4317:
URL: https://github.com/apache/cloudstack/pull/4317#discussion_r486875250
##########
File path: api/src/main/java/org/apache/cloudstack/api/response/NetworkResponse.java
##########
@@ -238,6 +238,10 @@
@Param(description = "If the network has redundant routers enabled", since = "4.11.1")
private Boolean redundantRouter;
+ @SerializedName(ApiConstants.ACL_NAME)
+ @Param(description = "ACL name associated with the VPC network")
Review comment:
@ravening will it be better to add a since tag here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #4317: Display acl name in listNetworks response
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #4317:
URL: https://github.com/apache/cloudstack/pull/4317#discussion_r486875250
##########
File path: api/src/main/java/org/apache/cloudstack/api/response/NetworkResponse.java
##########
@@ -238,6 +238,10 @@
@Param(description = "If the network has redundant routers enabled", since = "4.11.1")
private Boolean redundantRouter;
+ @SerializedName(ApiConstants.ACL_NAME)
+ @Param(description = "ACL name associated with the VPC network")
Review comment:
@ravening will it be better to add a since tag here?
##########
File path: api/src/main/java/org/apache/cloudstack/api/response/NetworkResponse.java
##########
@@ -238,6 +238,10 @@
@Param(description = "If the network has redundant routers enabled", since = "4.11.1")
private Boolean redundantRouter;
+ @SerializedName(ApiConstants.ACL_NAME)
+ @Param(description = "ACL name associated with the VPC network")
Review comment:
@ravening will it be better to add a since tag here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb merged pull request #4317: Display acl name in listNetworks response
Posted by GitBox <gi...@apache.org>.
andrijapanicsb merged pull request #4317:
URL: https://github.com/apache/cloudstack/pull/4317
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on a change in pull request #4317: Display acl name in listNetworks response
Posted by GitBox <gi...@apache.org>.
ravening commented on a change in pull request #4317:
URL: https://github.com/apache/cloudstack/pull/4317#discussion_r487008659
##########
File path: api/src/main/java/org/apache/cloudstack/api/response/NetworkResponse.java
##########
@@ -238,6 +238,10 @@
@Param(description = "If the network has redundant routers enabled", since = "4.11.1")
private Boolean redundantRouter;
+ @SerializedName(ApiConstants.ACL_NAME)
+ @Param(description = "ACL name associated with the VPC network")
Review comment:
@shwstppr made the change
##########
File path: api/src/main/java/org/apache/cloudstack/api/response/NetworkResponse.java
##########
@@ -238,6 +238,10 @@
@Param(description = "If the network has redundant routers enabled", since = "4.11.1")
private Boolean redundantRouter;
+ @SerializedName(ApiConstants.ACL_NAME)
+ @Param(description = "ACL name associated with the VPC network")
Review comment:
@shwstppr made the change
##########
File path: api/src/main/java/org/apache/cloudstack/api/response/NetworkResponse.java
##########
@@ -238,6 +238,10 @@
@Param(description = "If the network has redundant routers enabled", since = "4.11.1")
private Boolean redundantRouter;
+ @SerializedName(ApiConstants.ACL_NAME)
+ @Param(description = "ACL name associated with the VPC network")
Review comment:
@shwstppr made the change
##########
File path: api/src/main/java/org/apache/cloudstack/api/response/NetworkResponse.java
##########
@@ -238,6 +238,10 @@
@Param(description = "If the network has redundant routers enabled", since = "4.11.1")
private Boolean redundantRouter;
+ @SerializedName(ApiConstants.ACL_NAME)
+ @Param(description = "ACL name associated with the VPC network")
Review comment:
@shwstppr made the change
##########
File path: api/src/main/java/org/apache/cloudstack/api/response/NetworkResponse.java
##########
@@ -238,6 +238,10 @@
@Param(description = "If the network has redundant routers enabled", since = "4.11.1")
private Boolean redundantRouter;
+ @SerializedName(ApiConstants.ACL_NAME)
+ @Param(description = "ACL name associated with the VPC network")
Review comment:
@shwstppr made the change
##########
File path: api/src/main/java/org/apache/cloudstack/api/response/NetworkResponse.java
##########
@@ -238,6 +238,10 @@
@Param(description = "If the network has redundant routers enabled", since = "4.11.1")
private Boolean redundantRouter;
+ @SerializedName(ApiConstants.ACL_NAME)
+ @Param(description = "ACL name associated with the VPC network")
Review comment:
@shwstppr made the change
##########
File path: api/src/main/java/org/apache/cloudstack/api/response/NetworkResponse.java
##########
@@ -238,6 +238,10 @@
@Param(description = "If the network has redundant routers enabled", since = "4.11.1")
private Boolean redundantRouter;
+ @SerializedName(ApiConstants.ACL_NAME)
+ @Param(description = "ACL name associated with the VPC network")
Review comment:
@shwstppr made the change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on a change in pull request #4317: Display acl name in listNetworks response
Posted by GitBox <gi...@apache.org>.
ravening commented on a change in pull request #4317:
URL: https://github.com/apache/cloudstack/pull/4317#discussion_r487008659
##########
File path: api/src/main/java/org/apache/cloudstack/api/response/NetworkResponse.java
##########
@@ -238,6 +238,10 @@
@Param(description = "If the network has redundant routers enabled", since = "4.11.1")
private Boolean redundantRouter;
+ @SerializedName(ApiConstants.ACL_NAME)
+ @Param(description = "ACL name associated with the VPC network")
Review comment:
@shwstppr made the change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #4317: Display acl name in listNetworks response
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4317:
URL: https://github.com/apache/cloudstack/pull/4317#issuecomment-690098536
@rhtyd @davidjumani please review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org