You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Gary Gregory <ga...@gmail.com> on 2011/12/21 13:29:53 UTC
[sanselan] ColorConversionsTest failure
Does anyone else see this:
junit.framework.ComparisonFailure: {C: 0.0, M: 0.0, Y: 64.0, K: 64.0}
expected:<FFBFBF[8]F> but was:<FFBFBF[7]F>
at junit.framework.Assert.assertEquals(Assert.java:81)
at
org.apache.commons.sanselan.color.ColorConversionsTest.testCMYKtoRGB(ColorConversionsTest.java:51)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:592)
at junit.framework.TestCase.runTest(TestCase.java:164)
at junit.framework.TestCase.runBare(TestCase.java:130)
at junit.framework.TestResult$1.protect(TestResult.java:106)
at junit.framework.TestResult.runProtected(TestResult.java:124)
at junit.framework.TestResult.run(TestResult.java:109)
at junit.framework.TestCase.run(TestCase.java:120)
at junit.framework.TestSuite.runTest(TestSuite.java:230)
at junit.framework.TestSuite.run(TestSuite.java:225)
at
org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestReference.run(JUnit3TestReference.java:130)
at
org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197)
?
Gary
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: http://bit.ly/ECvg0
Spring Batch in Action: http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: [sanselan] ColorConversionsTest failure
Posted by Emmanuel Bourg <eb...@apache.org>.
Le 03/01/2012 22:06, Matt Benson a écrit :
> Ping, any of the sanselan/imaging guys want to tackle this?
I started looking at the CMYK to RGB conversion but it seems there are
different formulas floating around on Internet. I have yet to find an
authoritative source on this topic.
Emmanuel Bourg
Re: [sanselan] ColorConversionsTest failure
Posted by Matt Benson <gu...@gmail.com>.
Ping, any of the sanselan/imaging guys want to tackle this?
Matt
On Wed, Dec 21, 2011 at 6:55 AM, Emmanuel Bourg <eb...@apache.org> wrote:
> Le 21/12/2011 13:49, Gary Gregory a écrit :
>
>
>> Sorry, that kind of feels like passing the buck here ;) I wish I could
>> recall a French equivalent! :)
>
>
> Yeah that's called "Management" ;)
>
> Emmanuel Bourg
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [sanselan] ColorConversionsTest failure
Posted by Emmanuel Bourg <eb...@apache.org>.
Le 21/12/2011 13:49, Gary Gregory a écrit :
> Sorry, that kind of feels like passing the buck here ;) I wish I could
> recall a French equivalent! :)
Yeah that's called "Management" ;)
Emmanuel Bourg
Re: [sanselan] ColorConversionsTest failure
Posted by Gary Gregory <ga...@gmail.com>.
On Wed, Dec 21, 2011 at 7:44 AM, Emmanuel Bourg <eb...@apache.org> wrote:
> Le 21/12/2011 13:36, Gary Gregory a écrit :
>
>
> If you add a unit test, you should make sure it works IMO. Or, you should
>> @Ignore it.
>>
>
> Sorry I'm not keen to put the dust under the carpet. If there is an issue
> it should be visible. I let it to someone more knowledgeable on color
> spaces to review it.
>
Sorry, that kind of feels like passing the buck here ;) I wish I could
recall a French equivalent! :)
Gary
>
> Emmanuel Bourg
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: [sanselan] ColorConversionsTest failure
Posted by Emmanuel Bourg <eb...@apache.org>.
Le 21/12/2011 13:36, Gary Gregory a écrit :
> If you add a unit test, you should make sure it works IMO. Or, you should
> @Ignore it.
Sorry I'm not keen to put the dust under the carpet. If there is an
issue it should be visible. I let it to someone more knowledgeable on
color spaces to review it.
Emmanuel Bourg
Re: [sanselan] ColorConversionsTest failure
Posted by Gary Gregory <ga...@gmail.com>.
On Wed, Dec 21, 2011 at 7:34 AM, Emmanuel Bourg <eb...@apache.org> wrote:
> I do, the failure appeared after I moved the tests previously in
> ColorConversions into a proper JUnit test case. I don't think I broke the
> code, so I assume the issue was already there.
>
If you add a unit test, you should make sure it works IMO. Or, you should
@Ignore it.
Gary
>
> Emmanuel Bourg
>
>
> Le 21/12/2011 13:29, Gary Gregory a écrit :
>
> Does anyone else see this:
>>
>> junit.framework.**ComparisonFailure: {C: 0.0, M: 0.0, Y: 64.0, K: 64.0}
>> expected:<FFBFBF[8]F> but was:<FFBFBF[7]F>
>> at junit.framework.Assert.**assertEquals(Assert.java:81)
>> at
>> org.apache.commons.sanselan.**color.ColorConversionsTest.**testCMYKtoRGB(
>> **ColorConversionsTest.java:51)
>> at sun.reflect.**NativeMethodAccessorImpl.**invoke0(Native Method)
>> at
>> sun.reflect.**NativeMethodAccessorImpl.**invoke(**
>> NativeMethodAccessorImpl.java:**39)
>> at
>> sun.reflect.**DelegatingMethodAccessorImpl.**invoke(**
>> DelegatingMethodAccessorImpl.**java:25)
>> at java.lang.reflect.Method.**invoke(Method.java:592)
>> at junit.framework.TestCase.**runTest(TestCase.java:164)
>> at junit.framework.TestCase.**runBare(TestCase.java:130)
>> at junit.framework.TestResult$1.**protect(TestResult.java:106)
>> at junit.framework.TestResult.**runProtected(TestResult.java:**124)
>> at junit.framework.TestResult.**run(TestResult.java:109)
>> at junit.framework.TestCase.run(**TestCase.java:120)
>> at junit.framework.TestSuite.**runTest(TestSuite.java:230)
>> at junit.framework.TestSuite.run(**TestSuite.java:225)
>> at
>> org.eclipse.jdt.internal.**junit.runner.junit3.**JUnit3TestReference.run(
>> **JUnit3TestReference.java:130)
>> at
>> org.eclipse.jdt.internal.**junit.runner.TestExecution.**
>> run(TestExecution.java:38)
>> at
>> org.eclipse.jdt.internal.**junit.runner.RemoteTestRunner.**
>> runTests(RemoteTestRunner.**java:467)
>> at
>> org.eclipse.jdt.internal.**junit.runner.RemoteTestRunner.**
>> runTests(RemoteTestRunner.**java:683)
>> at
>> org.eclipse.jdt.internal.**junit.runner.RemoteTestRunner.**
>> run(RemoteTestRunner.java:390)
>> at
>> org.eclipse.jdt.internal.**junit.runner.RemoteTestRunner.**
>> main(RemoteTestRunner.java:**197)
>>
>> ?
>>
>> Gary
>>
>>
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: [sanselan] ColorConversionsTest failure
Posted by Emmanuel Bourg <eb...@apache.org>.
I do, the failure appeared after I moved the tests previously in
ColorConversions into a proper JUnit test case. I don't think I broke
the code, so I assume the issue was already there.
Emmanuel Bourg
Le 21/12/2011 13:29, Gary Gregory a écrit :
> Does anyone else see this:
>
> junit.framework.ComparisonFailure: {C: 0.0, M: 0.0, Y: 64.0, K: 64.0}
> expected:<FFBFBF[8]F> but was:<FFBFBF[7]F>
> at junit.framework.Assert.assertEquals(Assert.java:81)
> at
> org.apache.commons.sanselan.color.ColorConversionsTest.testCMYKtoRGB(ColorConversionsTest.java:51)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:592)
> at junit.framework.TestCase.runTest(TestCase.java:164)
> at junit.framework.TestCase.runBare(TestCase.java:130)
> at junit.framework.TestResult$1.protect(TestResult.java:106)
> at junit.framework.TestResult.runProtected(TestResult.java:124)
> at junit.framework.TestResult.run(TestResult.java:109)
> at junit.framework.TestCase.run(TestCase.java:120)
> at junit.framework.TestSuite.runTest(TestSuite.java:230)
> at junit.framework.TestSuite.run(TestSuite.java:225)
> at
> org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestReference.run(JUnit3TestReference.java:130)
> at
> org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
> at
> org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467)
> at
> org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683)
> at
> org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390)
> at
> org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197)
>
> ?
>
> Gary
>